Skip to content

Disable the activity lifecycle callbacks on app delete #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ constructor(
Log.d(TAG, "Sessions SDK disabled. Not listening to lifecycle events.")
} else {
firebaseApp.addLifecycleEventListener { _, _ ->
// Log.w(
// TAG,
// "FirebaseApp instance deleted. Sessions library will stop collecting data.",
// )
// TODO(mrober): Clean up on firebase app delete
Log.w(
TAG,
"FirebaseApp instance deleted. Sessions library will stop collecting data.",
)
sessionsActivityLifecycleCallbacks.onAppDelete()
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,23 @@ internal class SessionsActivityLifecycleCallbacks
@Inject
constructor(private val sharedSessionRepository: SharedSessionRepository) :
ActivityLifecycleCallbacks {

override fun onActivityResumed(activity: Activity) = sharedSessionRepository.appForeground()

override fun onActivityPaused(activity: Activity) = sharedSessionRepository.appBackground()
private var enabled = true

fun onAppDelete() {
enabled = false
}

override fun onActivityResumed(activity: Activity) {
if (enabled) {
sharedSessionRepository.appForeground()
}
}

override fun onActivityPaused(activity: Activity) {
if (enabled) {
sharedSessionRepository.appBackground()
}
}

override fun onActivityCreated(activity: Activity, savedInstanceState: Bundle?) = Unit

Expand Down
Loading