Skip to content

send session event based on data collection and setting config #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

send session event based on data collection and setting config #6852

merged 1 commit into from
Apr 9, 2025

Conversation

themiswang
Copy link
Contributor

send session event based on data collection and setting config

@themiswang themiswang requested review from mrober and tejasd April 9, 2025 14:48
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (2b1e056) to 79.85% (cfcf63d) by ?.

    45 individual files with coverage change

    FilenameBase (2b1e056)Merge (cfcf63d)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.12%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?62.50%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?78.57%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?22.22%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?34.04%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?62.50%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eW6h22SfRu.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Test Results

 32 files   32 suites   46s ⏱️
 68 tests  68 ✅ 0 💤 0 ❌
136 runs  136 ✅ 0 💤 0 ❌

Results for commit d835a51.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (2b1e056)Merge (cfcf63d)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (2b1e056)Merge (cfcf63d)Diff
    aar?196 kB? (?)
    apk (aggressive)?529 kB? (?)
    apk (release)?5.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/av252Ja40K.html

@themiswang themiswang merged commit 21ddec3 into sessions-sharedrepo Apr 9, 2025
30 of 31 checks passed
@themiswang themiswang deleted the sendSession branch April 9, 2025 16:13
mrober pushed a commit that referenced this pull request Apr 15, 2025
@themiswang @mrober
send session event based on data collection and setting config (#6852)
3080225 
send session event based on data collection and setting config
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
send session event based on data collection and setting config (#6852)
c2e6506 
send session event based on data collection and setting config
mrober pushed a commit that referenced this pull request May 5, 2025
@themiswang @mrober
send session event based on data collection and setting config (#6852)
138d404 
send session event based on data collection and setting config
@firebase firebase locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tejasd tejasd tejasd approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @google-oss-bot @tejasd @mrober