feat(auth): Update ActionCodeSettings to support link_domain and deprecate dynamic_link_domain
#884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errkk
approved these changes
Jun 3, 2025
|
@lahirumaramba @pashanka see here re: #883. In my org we're currently relying on this via a fork and would be great to get into main release. |
Xiaoshouzi-gh
approved these changes
Jul 7, 2025
huwmartin
force-pushed
the
action-code-settings-link-domain
branch
from
1d9d933 to
dfce7c1
Compare
jonathanedey
requested changes
Jul 18, 2025
There was a problem hiding this comment.
Thanks @huwmartin for putting this together! Overall LGTM with one minor change below.
jonathanedey
requested review from
egilmorez
and removed request for
OrlandriaH-G
jonathanedey
approved these changes
Jul 23, 2025
|
@jonathanedey thanks, lots of other issues when running |
|
@huwmartin, no worries, those were mainly because the branch was out of date. We made some lint changes in or last release and the CI here are using those settings. Thanks again for you contribution! |
jonathanedey
changed the title
ActionCodeSettings to support link_domain and deprecate dynamic_link_domain
jonathanedey
changed the title
ActionCodeSettings to support link_domain and deprecate dynamic_link_domainActionCodeSettings to support link_domain and deprecate dynamic_link_domain
jonathanedey
pushed a commit
that referenced
this pull request
Aug 13, 2025
…eprecate `dynamic_link_domain` (#884) * Add link_domain to ActionCodeSettings; update encode_action_code_settings to handle link_domain * Add handling for InvalidHostingLinkDomainError * Add deprecation warning for dynamic_link_domain * Update error message for InvalidHostingLinkDomainError * Fix lint * Add type hints to ActionCodeSettings * Fix f-string lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Firebase Dynamic Links will stop working August 25th 2025.
Migration instructions indicate that to use a custom domain one should update usage of
ActionCodeSettingsto uselinkDomain, see also in the Firebase Admin docs.We currently depend upon
generate_sign_in_with_email_linkto generate email links,firebase-admin-pythonhasn't been updated withlink_domainand currently only supportsdynamic_link_domain,firebase-admin-nodehas been updated with support forlinkDomainso I assume this should be officially supported, please let me know if this is not the case.See #883.
This PR updates
ActionCodeSettingsto acceptlink_domainand updatesencode_action_code_settingsto handlelink_domainwhen constructing request payload. I have also added definition for newInvalidHostingLinkDomainErrorerror.