Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding methods for fetching JSON representation of server template and the value source of the config values #850

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Adding methods for fetching JSON representation of server template and the value source of the config values #850

merged 4 commits into from
Jan 21, 2025

Conversation

pijushcs
Copy link

@pijushcs pijushcs commented Jan 9, 2025

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@pijushcs pijushcs marked this pull request as draft January 9, 2025 16:57
@pijushcs pijushcs marked this pull request as ready for review January 9, 2025 18:11
@pijushcs pijushcs requested a review from lahirumaramba January 9, 2025 18:11
lahirumaramba
lahirumaramba approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!
Please see my comment below

firebase_admin/remote_config.py Show resolved Hide resolved
@pijushcs pijushcs merged commit 0c6aaac into ssrc Jan 21, 2025
12 checks passed
@lahirumaramba lahirumaramba deleted the ssrc-updates branch January 21, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pijushcs @lahirumaramba