FDC: update api version, integration tests, and CONTRIBUTING.md #2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenarosaj
changed the title
stephenarosaj
changed the title
maneesht
reviewed
Sep 11, 2025
| expect(resp.data.users).to.deep.include(expectedUser); | ||
| expect(resp.data.users.length).to.greaterThan(1); | ||
| resp.data.users.forEach((user) => { | ||
| expect(expectedUserIds).to.include(user.id); |
There was a problem hiding this comment.
Why don't we compare the full objects here? You can use deep.equal to compare the arrays I believe
There was a problem hiding this comment.
We could check the full objects, but these objects are updated / edited by other test cases so I wanted to make the checks rely only on their IDs - the other tests which mutate the data check individual fields.
To make the tests even more air-tight, I could use different users / IDs for each test, rather than passing the same ID/object around to be used in different test scenarios. LMK WYT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1alphatov1