fix(app-check): support httpAgent in JwksFetcher
#2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanho
force-pushed
the
fix/jwks-http-proxy
branch
4 times, most recently
from
f94cf42
to
ae80c99
Compare
hermanho
force-pushed
the
fix/jwks-http-proxy
branch
from
ae80c99
to
6b55c00
Compare
lahirumaramba
changed the title
httpAgent in JwksFetcher
lahirumaramba
changed the title
httpAgent in JwksFetcherhttpAgent in JwksFetcher
lahirumaramba
approved these changes
Aug 29, 2024
|
For the CI build failed in 22.x, it is related to a bug in nodejs v22.7.0. It should be fixed in v22.8.0. I tested with v22.6.0 in local machine and no problem in emulator-based integration tests. |
Yep! Looks like they plan to release 22.8.0 next week. Let's wait and rerun the tests next week. If the Node release is delayed I can update the workflows to pin to 22.6.0 |
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: support httpAgent in JwksFetcher #2684