Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix People Service, and make Account-User UX more inutitive #142

Merged
merged 6 commits into from
Mar 30, 2024

Conversation

DovOps
Copy link
Contributor

@DovOps DovOps commented Mar 29, 2024

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS Corporate Contributor License Agreement.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

============================================
This fixes #130

  • Fixes some buggy routing logic around people service/gui relationship
  • Fixes a bug in .NET people service with response format
  • Makes the add-user-to-account flow more intuitive

Copy link

linux-foundation-easycla bot commented Mar 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for lucky-concha-f3599f failed.

Name Link
🔨 Latest commit d1358f9
🔍 Latest deploy log https://app.netlify.com/sites/lucky-concha-f3599f/deploys/660692669cf26500082ce54c

@DovOps DovOps marked this pull request as ready for review March 29, 2024 12:04
@DovOps
Copy link
Contributor Author

DovOps commented Mar 29, 2024

@maoo can you please take a look at the netlify failures? Seems more config/environmental than related to the code, and this bot appears to be a new addition.

@fhubi - I believe you need to make your profile public and re-run EasyCLA check, and/or click the link above within the failed step.

@maoo
Copy link
Member

maoo commented Mar 29, 2024

Base directory does not exist: /opt/build/repo/website

I suppose that this branch still doesn't include the docusaurus code, however the netflify github app is already running.

@DovOps
Copy link
Contributor Author

DovOps commented Mar 29, 2024

Thanks. That makes sense. I couldn't find the configuration to see how it applied on this branch. I will ignore those errors on this branch. As soon as the CLA matter is sorted, this can be merged, if you are happy with the code changed otherwise. I tested changed locally and via nginx ingress docker-compose.

@psmulovics
Copy link

@maoo, CLA side fixed, feel free to merge

@fhubi
Copy link

fhubi commented Mar 29, 2024

@DovOps It worked. The PR looks good to me.

@DovOps DovOps merged commit 8790810 into finos:main Mar 30, 2024
1 of 5 checks passed
@DovOps DovOps deleted the people-fix branch March 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add User to Account appears to be broken
6 participants