Style datagrid rows full width of the container

Author: texodus

examples/blocks/src/file/index.html

@@ -19,7 +19,7 @@
             <form class="my-form">
                 <p>Upload a CSV/Arrow file by dragging from your desktop and dropping onto the dashed region.</p>
                 <p>(Data is processed in browser, and never sent to any server).</p>
-                <input type="file" id="fileElem" multiple accept=".feather .arrow .csv" />
+                <input type="file" id="fileElem" multiple accept=".feather,.arrow,.csv" />
                 <label class="button" for="fileElem">Select a file</label>
             </form>
         </div>

packages/perspective-viewer-datagrid/src/less/pro.less

@@ -70,10 +70,19 @@ perspective-viewer-datagrid:not(.sub-cell-scroll-disabled) regular-table table {
             200% var(--regular-table--clip-y, 0)
         );
     }
+
+    thead tr:last-child:after {
+        transform: translate(var(--regular-table--transform-x, 0px));
+    }
+
+    tbody tr:not(:first-child):after {
+        transform: translate(var(--regular-table--transform-x, 0px));
+    }
 }
 
 regular-table {
     font-family: inherit;
+    --rt-hover--border-color: #c5c9d080;
 
     div[tabindex] {
         outline: none;
@@ -175,7 +184,6 @@ regular-table {
 
     table {
         position: absolute;
-        overflow: hidden;
         color: #666;
         outline: none;
     }

packages/perspective-viewer-datagrid/src/less/regular_table.less

@@ -258,6 +258,36 @@ regular-table table {
     }
 }
 
+regular-table table thead tr:last-child:after {
+    width: 10000px;
+    box-sizing: border-box;
+    display: block;
+    height: 23px;
+    content: " ";
+    border-bottom: 1px solid var(--inactive--border-color);
+}
+
+regular-table table tbody tr:after {
+    width: 10000px;
+    box-sizing: border-box;
+    display: block;
+    height: 23px;
+    content: " ";
+    border-top: 1px solid transparent;
+}
+
+regular-table table tbody tr:not(:first-child):after {
+    border-top: 1px solid var(--inactive--border-color);
+}
+
+regular-table table tbody tr:hover:not(:first-child):after {
+    border-top: 1px solid var(--rt-hover--border-color);
+}
+
+regular-table table tbody tr:hover + tr:after {
+    border-top: 1px solid var(--rt-hover--border-color);
+}
+
 @keyframes pulse_pos {
     0% {
         background-color: var(

packages/perspective-viewer-datagrid/src/less/row-hover.less

@@ -16,7 +16,8 @@ regular-table {
             th.psp-tree-leaf:not(.psp-row-selected):not(.psp-row-subselected),
         tr:hover
             th.psp-tree-label:not(.psp-row-selected):not(.psp-row-subselected),
-        tr:hover td:not(.psp-row-selected):not(.psp-row-subselected) {
+        tr:hover td:not(.psp-row-selected):not(.psp-row-subselected),
+        tr:hover:after {
             border-color: var(--rt-hover--border-color, #c5c9d080) !important;
             background-color: transparent;
             box-shadow: // 0px -2px 0px rgba(0,0,0,0.05),
@@ -46,7 +47,7 @@ regular-table {
 
             th:last-child,
             td:last-child {
-                border-right-width: 1px;
+                border-right-width: 0px;
                 border-right-color: transparent;
             }
         }

rust/perspective-viewer/Cargo.lock

@@ -125,11 +125,7 @@ perspective-string-column-style[theme="Pro Dark"] {
 
         table tbody tr {
 
-            td,
-            th {
                 --rt-hover--border-color: #61656e;
-                border-top-color: #3b3f46;
-            }
         }
     }
 

rust/perspective-viewer/src/themes/pro-dark.less

@@ -64,14 +64,21 @@ async function download_release_assets(releases) {
 async function publish_release_assets(releases) {
     if (process.env.COMMIT) {
         for (const release of releases) {
-            if (release.name.endsWith("whl")) {
+            if (
+                (release.name.endsWith("whl") ||
+                    release.name.endsWith("tar.gz")) &&
+                release.name.indexOf("wasm") === -1
+            ) {
                 sh`twine upload ${release.name}`.runSync();
-            } else {
+            } else if (release.name.endsWith(".tgz")) {
                 sh`npm publish ${release.name}`.runSync();
             }
         }
 
-        sh`cargo publish`.cwd("rust/perspective-viewer").runSync();
+        // `node_modules` is considered dirty and we've already checked git status below.
+        sh`cargo publish --allow-dirty`
+            .cwd("rust/perspective-viewer")
+            .runSync();
     } else {
         console.warn(`COMMIT not specified, aborting`);
     }