Skip to content

Folder path is now displayed when hovering a tab. (#6808) #9700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2022
Merged

Folder path is now displayed when hovering a tab. (#6808) #9700

merged 5 commits into from
Aug 12, 2022

Conversation

QuaintMako
Copy link
Contributor

@QuaintMako QuaintMako commented Aug 11, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added a HoverDisplayText field and property in TabItem.
  • Binded said property in xaml of Horizontal and Vertical Multitasking Controls.
  • Updated the function GetSelectedTabInfoAsync().

Validation
How did you test these changes?

  • [ X ] Built and ran the app

Note: INavigationControlItem defines HoverDisplayText as well, should we extract it and define a new interface, something like IHoverable ?

Screenshots
6808_proof

@yaira2 yaira2 self-requested a review August 11, 2022 14:53
@yaira2
Copy link
Member

yaira2 commented Aug 11, 2022

Note: INavigationControlItem defines HoverDisplayText as well, should we extract it and define a new interface, something like IHoverable ?

Good idea, do you want to do that as part of this PR?

@QuaintMako
Copy link
Contributor Author

Sure

Note: INavigationControlItem defines HoverDisplayText as well, should we extract it and define a new interface, something like IHoverable ?

Good idea, do you want to do that as part of this PR?

Sure thing, I will add this. Is there a namespace adapted for such interface?

@yaira2
Copy link
Member

yaira2 commented Aug 11, 2022

@d2dyno1

@QuaintMako
Copy link
Contributor Author

QuaintMako commented Aug 11, 2022 •
edited
Loading

I have already made the refactoring into an interface so the actual refactoring can be validated.
Now, it needs to be validated name-wise and placement-wise (Most likely wrong for now.)

yaira2
yaira2 reviewed Aug 11, 2022
View reviewed changes
yaira2
yaira2 previously approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@d2dyno1 do you want to look this over?

d2dyno1
d2dyno1 reviewed Aug 11, 2022
View reviewed changes
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 12, 2022
@yaira2 yaira2 mentioned this pull request Aug 12, 2022
Closed
@yaira2 yaira2 merged commit 233224b into files-community:main Aug 12, 2022
@QuaintMako QuaintMako deleted the 6808_DisplayFolderPathOnTabHover branch August 12, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display folder path when hovering over tab
3 participants
@QuaintMako @yaira2 @d2dyno1