Skip to content

Fix fulltrust process sometimes exiting on start #9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 19, 2022
Merged

Fix fulltrust process sometimes exiting on start #9580

merged 7 commits into from
Jul 19, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jul 18, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Previous PR Add exception handling to TerminateProcess #9573 only fixed a symptom but not the issue.
  • The "TerminateUwp" command was sometimes left saved in local settings so on startup the FTP was exiting. Call "TerminateUwp" only when starting Files though command line (it appears the only case in which it's needed to terminate "zombie" Files processes)
  • Added a couple of comments to remember what we're doing there
  • Removed some old code

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title [test][ignore] Fix fulltrust process sometimes exiting on start Jul 18, 2022
@yaira2
Copy link
Member

yaira2 commented Jul 19, 2022

for real

I think I've seen you say this before 😅

yaira2
yaira2 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 19, 2022
@yaira2 yaira2 merged commit 695111c into files-community:main Jul 19, 2022
@gave92 gave92 deleted the issue_procid branch July 19, 2022 06:59
@yaira2 yaira2 mentioned this pull request Jul 20, 2022
Closed
@gave92 gave92 mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

设为默认资源管理器后回收站无法加载
2 participants
@gave92 @yaira2