Skip to content

Display already loaded entries while loading files in a directory #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

Display already loaded entries while loading files in a directory #731

merged 2 commits into from
May 4, 2020

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented May 1, 2020 •
edited
Loading

  • Fix a potential crashing at startup due to null reference
  • Display already loaded entries while loading files in a directory (akas. Display As You Go), which got user experience improved a lot
  • Sorting entries won't take current position to the top of the list

@hez2010 hez2010 changed the title Display loaded part while loading Display already loaded entries while loading files in a directory May 1, 2020
@ghost ghost added the needs - code review label May 1, 2020
@yaira2
Copy link
Member

yaira2 commented May 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hez2010
Copy link
Member Author

hez2010 commented May 2, 2020

CI failure is irrelevant with this PR.

@yaira2
Copy link
Member

yaira2 commented May 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 requested a review from lukeblevins May 3, 2020 01:54
@yaira2
Copy link
Member

yaira2 commented May 3, 2020

@hez2010 I sorted out the issue with the pipeline, I would like to get a review from @duke7553 before merging but from my end everything looks good.

lukeblevins
lukeblevins approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukeblevins lukeblevins added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 4, 2020
@yaira2 yaira2 merged commit 89e8937 into files-community:develop May 4, 2020
BuraChuhadar pushed a commit to BuraChuhadar/files-uwp that referenced this pull request May 18, 2020
@hez2010 @BuraChuhadar
Display already loaded entries while loading files in a directory (fi…
18d4dc3 
…les-community#731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hez2010 @yaira2 @lukeblevins