Moved the sidebar settings to the appearance settings page #6688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you share a screenshot? |
|
|
|
I'm concerned about the text clipping. While it looks fine in English, it may not look as good in German for instance. |
|
@d2dyno1 yes, the text clipping will be resolved when the navigation view is restyled and more pages are merged/reorganized. |
|
I suppose I shouldn't care about the close button overlapping the "About" item at this point right? |
gave92
reviewed
Nov 3, 2021
Pretend it's not there 😉 |
gave92
approved these changes
Nov 3, 2021
d2dyno1
approved these changes
Nov 3, 2021
gave92
added
ready to merge
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future PRs will