Skip to content

Switch quicklook previewed file on selection change #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2021
Merged

Switch quicklook previewed file on selection change #6543

merged 4 commits into from
Oct 20, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 17, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Calls quicklook to switch previewed file when selected item changes in Files

Validation
How did you test these changes?

  • Built and ran the app

d2dyno1
d2dyno1 suggested changes Oct 17, 2021
View reviewed changes
@gave92 gave92 requested a review from d2dyno1 October 17, 2021 18:59
d2dyno1
d2dyno1 approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d2dyno1 d2dyno1 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 17, 2021
@yaira2 yaira2 requested a review from BanCrash October 17, 2021 19:12
@yaira2 yaira2 added needs - code review and removed ready to merge Pull requests that are approved and ready to merge labels Oct 17, 2021
BanCrash
BanCrash approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 20, 2021
@yaira2 yaira2 merged commit a515957 into files-community:main Oct 20, 2021
@yaira2
Copy link
Member

yaira2 commented Oct 20, 2021

@gave92 thank you!

@yaira2 yaira2 mentioned this pull request Oct 20, 2021
Closed
@gave92 gave92 deleted the issue_6540 branch October 20, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BanCrash BanCrash BanCrash approved these changes

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch items arrow keys or mouse click QuickLook don't change image
4 participants
@gave92 @yaira2 @BanCrash @d2dyno1