Skip to content

Fix edit tags & edit terminals buttons in settings #6236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2021
Merged

Fix edit tags & edit terminals buttons in settings #6236

merged 2 commits into from
Sep 30, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Sep 26, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Fix edit tags & edit terminals button Fix edit tags & edit terminals buttons in settings Sep 26, 2021
@yaira2 yaira2 requested a review from BanCrash September 26, 2021 15:58
d2dyno1
d2dyno1 reviewed Sep 27, 2021
View reviewed changes
d2dyno1
d2dyno1 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@d2dyno1 d2dyno1 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 29, 2021
@yaira2 yaira2 added needs - code review and removed ready to merge Pull requests that are approved and ready to merge labels Sep 30, 2021
BanCrash
BanCrash approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 30, 2021
@yaira2 yaira2 merged commit 087cf8f into files-community:main Sep 30, 2021
@yaira2 yaira2 mentioned this pull request Sep 30, 2021
Closed
@gave92 gave92 deleted the issue_6234 branch September 30, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BanCrash BanCrash BanCrash approved these changes

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit File Tags button does not work
4 participants
@gave92 @BanCrash @d2dyno1 @yaira2