-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Code Quality: Added empty projects for Files.App.Controls and Files.App.UITests #15784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8d843bc
Added Empty Files.App.Controls and Files.App.UITests projects
mdtauk 73a8079
Removed Any CPU entries which were added automatically
mdtauk 23a0238
Update tests/Files.App.UITests/Package.appxmanifest
0x5bfa d0c5be0
Update Files.App.UITests.csproj
0x5bfa 81b11db
Update Package.appxmanifest
0x5bfa 02c41b9
Update Files.App.UITests.csproj
0x5bfa 87b8045
Update Package.appxmanifest
0x5bfa 8540aef
Update Files.App.Controls.csproj
0x5bfa 5ae9442
Update Files.sln
0x5bfa fda7d64
Update Files.sln
0x5bfa 65a7fd2
Update Files.sln
0x5bfa 9549ff1
Remove UWP targeting and fetch the versions for Desktop
0x5bfa 63f8f62
Create Directory.Build.props
0x5bfa 60844e9
Update Files.App.Controls.csproj
0x5bfa 5fc0fda
Update Files.App.UITests.csproj
0x5bfa 51a187d
Merge branch 'main' into mdta-empty-projects
mdtauk 443d71f
Merge branch 'main' into mdta-empty-projects
mdtauk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <!-- Copyright (c) 2023 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
| <Project> | ||
|
|
||
| <PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'"> | ||
| <Nullable>enable</Nullable> | ||
| <Configurations>Debug;Stable;Preview;Store</Configurations> | ||
| <Company>Files Community</Company> | ||
| <Copyright>Copyright (c) 2024 Files Community.</Copyright> | ||
| <AssemblyCompany>Files Community</AssemblyCompany> | ||
| <AssemblyCopyright>Copyright (c) 2024 Files Community</AssemblyCopyright> | ||
| <AssemblyProduct>Files</AssemblyProduct> | ||
| <NeutralLanguage>en-US</NeutralLanguage> | ||
| <Platforms>x86;x64;ARM64</Platforms> | ||
| <RuntimeIdentifiers>win-x86;win-x64;win-arm64</RuntimeIdentifiers> | ||
| <LangVersion>latest</LangVersion> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <!-- <ApplicationIcon>../Files.App (Package)/Assets/AppTiles/Release/Logo.ico</ApplicationIcon> --> | ||
| <DefineConstants Condition="'$(Configuration)' == 'Debug'">TRACE;DEBUG;NETFX_CORE</DefineConstants> | ||
| <DefineConstants Condition="'$(Configuration)' != 'Debug'">TRACE;RELEASE;NETFX_CORE</DefineConstants> | ||
| <Optimize Condition="'$(Configuration)' != 'Debug'">true</Optimize> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!-- Copyright (c) 2024 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0-windows10.0.22621.0</TargetFramework> | ||
| <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion> | ||
| <UseWinUI>true</UseWinUI> | ||
| <SupportedOSPlatformVersion>10.0.19041.0</SupportedOSPlatformVersion> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="CommunityToolkit.WinUI.UI" Version="7.1.2" /> | ||
| <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240311000" /> | ||
| <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <!-- Copyright (c) 2024 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
| <Application | ||
| x:Class="Files.App.UITests.App" | ||
| xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| xmlns:local="using:Files.App.UITests"> | ||
| <Application.Resources> | ||
| <ResourceDictionary> | ||
| <ResourceDictionary.MergedDictionaries> | ||
| <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" /> | ||
| <!-- Other merged dictionaries here --> | ||
| </ResourceDictionary.MergedDictionaries> | ||
| <!-- Other app resources here --> | ||
| </ResourceDictionary> | ||
| </Application.Resources> | ||
| </Application> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Copyright (c) 2024 Files Community | ||
| // Licensed under the MIT License. See the LICENSE. | ||
|
|
||
| using Microsoft.UI.Xaml; | ||
| using Microsoft.UI.Xaml.Controls; | ||
| using Microsoft.UI.Xaml.Controls.Primitives; | ||
| using Microsoft.UI.Xaml.Data; | ||
| using Microsoft.UI.Xaml.Input; | ||
| using Microsoft.UI.Xaml.Media; | ||
| using Microsoft.UI.Xaml.Navigation; | ||
| using Microsoft.UI.Xaml.Shapes; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.IO; | ||
| using System.Linq; | ||
| using System.Runtime.InteropServices.WindowsRuntime; | ||
| using Windows.ApplicationModel; | ||
| using Windows.ApplicationModel.Activation; | ||
| using Windows.Foundation; | ||
| using Windows.Foundation.Collections; | ||
|
|
||
| namespace Files.App.UITests | ||
| { | ||
| /// <summary> | ||
| /// Provides application-specific behavior to supplement the default Application class. | ||
| /// </summary> | ||
| public partial class App : Application | ||
| { | ||
| /// <summary> | ||
| /// Initializes the singleton application object. This is the first line of authored code | ||
| /// executed, and as such is the logical equivalent of main() or WinMain(). | ||
| /// </summary> | ||
| public App() | ||
| { | ||
| this.InitializeComponent(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Invoked when the application is launched. | ||
| /// </summary> | ||
| /// <param name="args">Details about the launch request and process.</param> | ||
| protected override void OnLaunched(Microsoft.UI.Xaml.LaunchActivatedEventArgs args) | ||
| { | ||
| m_window = new MainWindow(); | ||
| m_window.Activate(); | ||
| } | ||
|
|
||
| private Window m_window; | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+283 Bytes
tests/Files.App.UITests/Assets/Square44x44Logo.targetsize-24_altform-unplated.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <!-- Copyright (c) 2024 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>WinExe</OutputType> | ||
| <TargetFramework>net8.0-windows10.0.22621.0</TargetFramework> | ||
| <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion> | ||
| <PublishProfile>win-$(Platform).pubxml</PublishProfile> | ||
| <UseWinUI>true</UseWinUI> | ||
| <EnableMsixTooling>true</EnableMsixTooling> | ||
| <SupportedOSPlatformVersion>10.0.19041.0</SupportedOSPlatformVersion> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Content Include="Assets\SplashScreen.scale-200.png" /> | ||
| <Content Include="Assets\LockScreenLogo.scale-200.png" /> | ||
| <Content Include="Assets\Square150x150Logo.scale-200.png" /> | ||
| <Content Include="Assets\Square44x44Logo.scale-200.png" /> | ||
| <Content Include="Assets\Square44x44Logo.targetsize-24_altform-unplated.png" /> | ||
| <Content Include="Assets\StoreLogo.png" /> | ||
| <Content Include="Assets\Wide310x150Logo.scale-200.png" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" /> | ||
| <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240627000" /> | ||
| <Manifest Include="$(ApplicationManifest)" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Allows the Single-project MSIX Packaging Tools extension to be activated for this project even if the Windows App SDK Nuget package has not yet been restored. --> | ||
| <ItemGroup Condition="'$(DisableMsixProjectCapabilityAddedByProject)'!='true' and '$(EnableMsixTooling)'=='true'"> | ||
| <ProjectCapability Include="Msix" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Allows the Solution Explorer "Package and Publish" context menu entry to be enabled for this project even if the Windows App SDK Nuget package has not yet been restored. --> | ||
| <PropertyGroup Condition="'$(DisableHasPackageAndPublishMenuAddedByProject)'!='true' and '$(EnableMsixTooling)'=='true'"> | ||
| <HasPackageAndPublishMenu>true</HasPackageAndPublishMenu> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!-- Copyright (c) 2024 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
| <Window | ||
| x:Class="Files.App.UITests.MainWindow" | ||
| xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| xmlns:local="using:Files.App.UITests" | ||
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| mc:Ignorable="d"> | ||
|
|
||
| <StackPanel | ||
| HorizontalAlignment="Center" | ||
| VerticalAlignment="Center" | ||
| Orientation="Horizontal"> | ||
| <Button x:Name="myButton" Click="myButton_Click">Click Me</Button> | ||
| </StackPanel> | ||
| </Window> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright (c) 2024 Files Community | ||
| // Licensed under the MIT License. See the LICENSE. | ||
|
|
||
| using Microsoft.UI.Xaml; | ||
| using Microsoft.UI.Xaml.Controls; | ||
| using Microsoft.UI.Xaml.Controls.Primitives; | ||
| using Microsoft.UI.Xaml.Data; | ||
| using Microsoft.UI.Xaml.Input; | ||
| using Microsoft.UI.Xaml.Media; | ||
| using Microsoft.UI.Xaml.Navigation; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.IO; | ||
| using System.Linq; | ||
| using System.Runtime.InteropServices.WindowsRuntime; | ||
| using Windows.Foundation; | ||
| using Windows.Foundation.Collections; | ||
|
|
||
| namespace Files.App.UITests | ||
| { | ||
| /// <summary> | ||
| /// An empty window that can be used on its own or navigated to within a Frame. | ||
| /// </summary> | ||
| public sealed partial class MainWindow : Window | ||
| { | ||
| public MainWindow() | ||
| { | ||
| this.InitializeComponent(); | ||
| } | ||
|
|
||
| private void myButton_Click(object sender, RoutedEventArgs e) | ||
| { | ||
| myButton.Content = "Clicked"; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- Copyright (c) 2024 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
| <Package | ||
| xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" | ||
| xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" | ||
| xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" | ||
| xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" | ||
| IgnorableNamespaces="uap rescap"> | ||
|
|
||
| <Identity | ||
| Name="322c0e3e-93e4-45cc-bb2e-f76af7960635" | ||
| Publisher="CN=Files" | ||
| Version="1.0.0.0" /> | ||
|
|
||
| <mp:PhoneIdentity PhoneProductId="322c0e3e-93e4-45cc-bb2e-f76af7960635" PhonePublisherId="00000000-0000-0000-0000-000000000000"/> | ||
|
|
||
| <Properties> | ||
| <DisplayName>Files UI tests app</DisplayName> | ||
| <PublisherDisplayName>Files</PublisherDisplayName> | ||
| <Logo>Assets\StoreLogo.png</Logo> | ||
| </Properties> | ||
|
|
||
| <Dependencies> | ||
| <TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.19041.0" MaxVersionTested="10.0.22621.0" /> | ||
| </Dependencies> | ||
|
|
||
| <Resources> | ||
| <Resource Language="x-generate"/> | ||
| </Resources> | ||
|
|
||
| <Applications> | ||
| <Application Id="App" | ||
| Executable="$targetnametoken$.exe" | ||
| EntryPoint="$targetentrypoint$"> | ||
| <uap:VisualElements | ||
| DisplayName="Files UI tests app" | ||
| Description="Files UI tests app. This test app is provided for Files development use." | ||
| BackgroundColor="transparent" | ||
| Square150x150Logo="Assets\Square150x150Logo.png" | ||
| Square44x44Logo="Assets\Square44x44Logo.png"> | ||
| <uap:DefaultTile Wide310x150Logo="Assets\Wide310x150Logo.png" /> | ||
| <uap:SplashScreen Image="Assets\SplashScreen.png" /> | ||
| </uap:VisualElements> | ||
| </Application> | ||
| </Applications> | ||
|
|
||
| <Capabilities> | ||
| <rescap:Capability Name="runFullTrust" /> | ||
| </Capabilities> | ||
| </Package> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.