Skip to content

Code Quality: Improved the way of instancing OpacityIconModel #14603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jan 31, 2024

Summary

As the title.

PR Checklist

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 31, 2024
@yaira2 yaira2 merged commit d76599a into files-community:main Jan 31, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Improve-ContexrFlyoutModel branch February 1, 2024 03:35
@hishitetsu
Copy link
Member

@0x5bfa @yaira2 This change prevents the context menu from being displayed.
image

@yaira2
Copy link
Member

yaira2 commented Feb 1, 2024

I reverted the PR

@yaira2
Copy link
Member

yaira2 commented Feb 1, 2024

@0x5bfa in the future, please use the official pull request template so we can confirm the changes were properly tested.

@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 1, 2024

i've tested around changes since the last happening like this other than this kind of change. I'll make sure. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants