Skip to content

Fix: Fixed issue where search results would sometimes use the Columns View #14539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 23, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Issue with Search Page Layout Synchronization #13439...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Set folder location to use Columns View
    2. Submit a search and confirm it uses the Details View to display the results
    3. Submit another search and confirm it's still using the Details View
    4. Go back to the original location and confirm it uses the Columns View

Screenshots (optional)
Add screenshots here.

Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 24, 2024
@yaira2 yaira2 merged commit 0fb0427 into main Jan 24, 2024
@yaira2 yaira2 deleted the ya/FixSearchColumns branch January 24, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Issue with Search Page Layout Synchronization
2 participants