Skip to content

Feature: Added support for cycling tabs via mouse scrolling #14123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

SGrahambo
Copy link
Contributor

Babies first pull request. So forgive me if I accidently something.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Cycle tabs via mouse scrolling #13550

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Create multiple tabs.
    3. Hover pointer over tab and use mousewheel to cycle tabs.
    4. Use mousewheel everywhere else to make sure no other mousewheel behaviour is changed.

@yaira2 yaira2 changed the title Feature: Cycle tabs via mouse scrolling (#13550) Feature: Added support for cycling tabs via mouse scrolling Nov 30, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 30, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 30, 2023

@SGrahambo fyi, in the future you can check the status of an issue to see if it's marked as "ready to build".

@yaira2 yaira2 merged commit 6bbe47c into files-community:main Nov 30, 2023
@SGrahambo SGrahambo deleted the TabMouseWheel branch December 1, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Cycle tabs via mouse scrolling
2 participants