Skip to content

Fix: Fixed issue where double-clicking on column headers would navigate up #13840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix: Fixed issue where double-clicking on column headers would navigate up #13840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
661e223
Fix the issue
RieBi Nov 13, 2023
00927a4
Merge branch 'main' into fix-double-click-on-column-header-bug
RieBi Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@
Padding="24,0,0,0"
BorderBrush="{ThemeResource DividerStrokeColorDefaultBrush}"
BorderThickness="0,0,0,1"
DoubleTapped="FileListHeader_DoubleTapped"
PointerPressed="Grid_PointerPressed">

<!-- Header Grid MenuFlyout -->
Expand Down
6 changes: 6 additions & 0 deletions src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,12 @@ private void FileList_LosingFocus(UIElement sender, LosingFocusEventArgs args)
args.TryCancel();
}

private void FileListHeader_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)
{
// Fixes an issue where double clicking the column header would navigate back as if clicking on empty space
e.Handled = true;
}

private static GitProperties GetEnabledGitProperties(ColumnsViewModel columnsViewModel)
{
var enableStatus = !columnsViewModel.GitStatusColumn.IsHidden && !columnsViewModel.GitStatusColumn.UserCollapsed;
Expand Down