Skip to content

Fix: Fixed issue with file preview in column layout #12284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Issue with file preview in column layout #12227

This PR also handles a null exception

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes? (I used @ZLAllen steps)
    1. Open "Files"
    2. Select "Documents"
    3. Change View Layout to "Columns"
    4. Enable Preview Panel
    5. Click any items in the first level, the detail shows up correctly in the preview.
    6. Select a folder and click on an item at the second level, the preview is not rendered. Select a different item or lose focus of the current selection and reselect the item will cause it to render correctly in the preview.

@yaira2 yaira2 changed the title Fix: Issue with file preview in column layout Fix: Fixed issue with file preview in column layout May 5, 2023
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 7, 2023
@yaira2
Copy link
Member

yaira2 commented May 7, 2023

Thank you

@yaira2 yaira2 merged commit c250095 into files-community:main May 7, 2023
@ferrariofilippo ferrariofilippo deleted the Fix_File_Preview branch May 8, 2023 07:18
hishitetsu pushed a commit to hishitetsu/Files that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Issue with file preview in column layout
4 participants