Skip to content

Feature: Display Restore All Items when right clicking recycle bin on the sidebar #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Removed the need for the context to restore the recycle bin, now using Vanara's restore instead.
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Tried the Restore All action from the context menu within the recycle bin page.
    2. Tried the Restore All action from the inner bar when in the recycle bin page.

Screenshots
10048

@yaira2 yaira2 changed the title Feature: Restore All Items now available on the Sidebar Feature: Display Restore All Items when right clicking recycle bin on the sidebar Apr 23, 2023
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me!

@yaira2 yaira2 merged commit b4deafc into files-community:main Apr 25, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 25, 2023
@QuaintMako QuaintMako deleted the RestoreSidebar branch April 25, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add restore option when right clicking recycle bin on the sidebar
3 participants