RichCommands: Switch tabs command

[ferrariofilippo]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related Generalizing Rich Command Usage #11481
  Closes Bug: Changing tab with keyboard doesn't update address bar #6111
  Related Feature: Only execute certain actions once #11737 (You can hold down Ctrl + Tab to switch more than once)

Details

• Ctrl + Tab and Ctrl + Shift + Tab shortcuts
• Seems to fix Bug: Changing tab with keyboard doesn't update address bar #6111 (I can't reproduce it so I think is fixed)
• Should I introduce a common base action to reduce code dupication or is it overkill?
  -Ctrl + W or Ctrl + F4 to close current tab

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open some tabs
  2. Swap active tab using shortcuts

[yaira2]

Should I introduce a common base action to reduce code dupication or is it overkill?

It's good as is 👍

[yaira2]

(You can hold down Ctrl + Tab to switch more than once)

Apparently Edge only allows it once, do you think we should do the same?

[ferrariofilippo]

Apparently Edge only allows it once, do you think we should do the same?

After some testing I think we should do that too. You can't really predict where you will land if you keep pressing Ctrl + Tab (unless we introduce some kind of delay so that you could choose where to stop)

[0x5bfa]

Coding concerns

[yaira2]

LGTM