Skip to content

Feature: Add support for removing tag in the details layout #11238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details

  • I had to use a different Tapped event because using TagItem_Tapped, FontIcon was passed in as a TextBlock and there was no way to differentiate it from TagName TextBlock.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

DeleteTags.mp4

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit e73396b into files-community:main Feb 12, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 12, 2023
@ferrariofilippo ferrariofilippo deleted the Delete_Tags_Details branch February 14, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for removing tag in the details layout
2 participants