Feature: Add shell context menu for widgets

[hecksmosis]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Adds context menu items for widgets
• Closes Feature: Add shell items to widgets right click menu #5888

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

[yaira2]

Should we switch to CommandBarFlyout to be more consistent with the right click menu in other places?

[ferrariofilippo]

Also, Button_RightTapped and LoadShellMenuItems share almost all the code in all widgets. You may create an helper class to reduce code duplication

[hecksmosis]

I don't know if we can add the helper class for the Button_RightTapped because some use Grid

[ferrariofilippo]

LGTM

[yaira2]

Just took a quick look and this much closer to what I had in mind. Will do a full review later but it's looking good.

[yaira2]

@hecksmosis functionality looks good too, I wonder if we should move options like properties and open with to the main menu. Just trying to think of ways to make it a little more consistent with the right click menu in the different layout modes.

[hecksmosis]

@hecksmosis functionality looks good too, I wonder if we should move options like properties and open with to the main menu. Just trying to think of ways to make it a little more consistent with the right click menu in the different layout modes.

I think properties is in the main menu already

[hecksmosis]

Do you want to add properties to recent files?

[yaira2]

Yes, properties, open with and add to favorites.

[yaira2]

Any idea why it's showing these icons?

[hecksmosis]

Yes, properties, open with and add to favorites.

Add to favorites wouldn't make sense as only files appear there @yaira2

[yaira2]

Good point, comes back to the fact that we don't show pinned files yet. We can probably hide the menu item for that.

[hecksmosis]

The icons being wrong is because I didn't notice

[hecksmosis]

I fixed the icons and added the open with menu, but I haven't been able to add the properties menu as it shows incomplete, help would be appreciated in that aspect.

[yaira2]

I think it's okay for now, I'll try to finish reviewing today.

[d2dyno1]

Some nits 🙂

[hecksmosis]

@d2dyno1 Is it ok now?

[d2dyno1]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yaira2]

It's not loading on recent files for me but I don't want to hold this back so let's merge as is.