Code Quality: Removing PaneHolder to solely use PreviewPaneHolder #10979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Files into ViewsSmallRefactoring
QuaintMako
changed the title
yaira2
reviewed
Jan 11, 2023
yaira2
added
the
ready to merge
Co-authored-by: yaira2 <39923744+yaira2@users.noreply.github.com>
yaira2
reviewed
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
The
Panesystem surrounding thePreviewPanehad no other use other than display said preview. While the system had been designed with other purposes in mind, they never came to fruction. It creates unneeded load on the app and complexity.This PR removes the
Panesystem altogether, instead displaying directly thePreviewPane.Validation
How did you test these changes?
Screenshots
The behavior of the app after the refactoring :