Fix: Fixed issue with creating shortcuts in libraries #10913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
There was a problem hiding this comment.
LGTM and it works!
This fix should be added also when CreateShortcutDialogViewModel is instantiated (added in #10879)
I think it might be worth creating a method that returns CurrentPath (WorkingDirectory or DefaultSaveLibrary) since it might be needed in other parts of the code too
QuaintMako
reviewed
Jan 16, 2023
src/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs
Outdated
Show resolved
Hide resolved
QuaintMako
previously approved these changes
Jan 17, 2023
Can you fix this? Otherwise we would need a different PR to fix the same bug |
…Files into fix_library_shortcut
|
Done. |
QuaintMako
approved these changes
Jan 22, 2023
yaira2
added
ready to merge
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?