Skip to content

Feature: Added detection for Nutstore cloud #10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 30, 2022
Merged

Feature: Added detection for Nutstore cloud #10890

merged 10 commits into from
Dec 30, 2022

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Dec 30, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Feature: Add support for Nutstore cloud Feature: Added support for Nutstore cloud Dec 30, 2022
@yaira2 yaira2 changed the title Feature: Added support for Nutstore cloud Feature: Added detection for Nutstore cloud Dec 30, 2022
@yaira2
Copy link
Member

yaira2 commented Dec 30, 2022

@hecksmosis can you update the documentation on the Files website?

yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Dec 30, 2022
@hecksmosis
Copy link
Contributor Author

To update the website, do I open a PR there?

@yaira2
Copy link
Member

yaira2 commented Dec 30, 2022

Yes

@hecksmosis
Copy link
Contributor Author

Should I replace Environment.GetEnvironmentVariable("ProgramFiles") with the constant everywhere?

@hecksmosis
Copy link
Contributor Author

Is it ok now?

yaira2
yaira2 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Dec 30, 2022
@yaira2 yaira2 merged commit 8a10983 into files-community:main Dec 30, 2022
@hecksmosis hecksmosis mentioned this pull request Jan 10, 2023
Merged
1 task
@wangfu91 wangfu91 mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add Nutstore cloud drive support
2 participants
@hecksmosis @yaira2