Skip to content

Feature: Added option to create new shortcuts #10879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 6, 2023
Merged

Feature: Added option to create new shortcuts #10879

merged 21 commits into from
Jan 6, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

Screenshots (optional)
6
4
5

@yaira2 yaira2 changed the title Create Shortcut from New Item Menu Feature: Added shortcut to new item menu Dec 29, 2022
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
yaira2
yaira2 reviewed Dec 30, 2022
View reviewed changes
@ferrariofilippo
Copy link
Contributor Author

With the latest commit I added a TextBlock to inform the user when the destination is invalid. I kept it simple as I'm not good with UI.
Here's a picture of how it looks:
Screenshot_20221230_231633

gave92
gave92 reviewed Dec 30, 2022
View reviewed changes
jiejasonliu
jiejasonliu reviewed Dec 31, 2022
View reviewed changes
Copy link
Contributor

@jiejasonliu jiejasonliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine to me, left some comments regarding spacing and spelling

yaira2
yaira2 reviewed Jan 1, 2023
View reviewed changes
yaira2
yaira2 reviewed Jan 4, 2023
View reviewed changes
yaira2
yaira2 reviewed Jan 4, 2023
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Jan 4, 2023

  1. Should "Continue" be renamed to "Create"?
  2. What is the shortcut named?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Jan 4, 2023 •
edited
Loading

  1. Should "Continue" be renamed to "Create"?

I named it "Continue" to reproduce issue's UI

  1. What is the shortcut named?

It depends:

  • if the destination is a file -> "<fileName> - shortcut.lnk"
  • if the destination is a folder -> "<folderName> - shortcut.lnk"
  • if the destination is an URL -> "<hostname> -shortcut.url"

Edit. At the moment if a shortcut with the same name already exists, it will be replaced. I'll change this so that a number will be added at the end, like we're already doing for other files

@yaira2
Copy link
Member

yaira2 commented Jan 4, 2023

I named it "Continue" to reproduce issue's UI

That was left over from the original concept where clicking continue would open another page.

yaira2
yaira2 reviewed Jan 4, 2023
View reviewed changes
yaira2
yaira2 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested review from jiejasonliu and gave92 and removed request for jiejasonliu January 5, 2023 20:58
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 6, 2023
@yaira2 yaira2 merged commit cfabfc9 into files-community:main Jan 6, 2023
@yaira2 yaira2 changed the title Feature: Added shortcut to new item menu Feature: Added option to create new shortcuts Jan 6, 2023
@ferrariofilippo ferrariofilippo deleted the Feature_Create_Shortcut branch January 6, 2023 20:27
QuaintMako pushed a commit to QuaintMako/Files that referenced this pull request Jan 8, 2023
@ferrariofilippo @QuaintMako
Feature: Added option to create new shortcuts (files-community#10879)
555f0b0
@ferrariofilippo ferrariofilippo mentioned this pull request Jan 19, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiejasonliu jiejasonliu jiejasonliu left review comments

@gave92 gave92 gave92 approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for creating shortcuts from the new item menu
4 participants
@ferrariofilippo @yaira2 @gave92 @jiejasonliu