Skip to content

Fix: Fixed issue where the wrong recent item was being removed #10847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 26, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested a review from hez2010 December 26, 2022 23:37
@yaira2 yaira2 changed the title Fix: Fix wrong recent element being removed Fix: Fixed issue where the wrong recent item was being removed Dec 26, 2022
@hez2010
Copy link
Member

hez2010 commented Dec 27, 2022

Changes LGTM, but this doesn't fix the linked issue. I can still reproduce the issue with the fix in this PR.

@gave92
Copy link
Member Author

gave92 commented Dec 27, 2022

The issue about powertoys or the issue about not removing the correct item?
If the second, could you share a screen recording?

@hez2010
Copy link
Member

hez2010 commented Dec 27, 2022

The issue about powertoys or the issue about not removing the correct item? If the second, could you share a screen recording?

The issue about powertoys. Removing items from the recent list can still trigger the locksmith open, and the item didn't get removed in the end.

@gave92
Copy link
Member Author

gave92 commented Dec 27, 2022

Ah ok here I'm only fixing the issue about removing the wrong item when powertoys is off. I've changed the description to not close the issue.

Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 27, 2022
@yaira2 yaira2 merged commit 31721fe into files-community:main Dec 27, 2022
@gave92 gave92 deleted the issue_10820 branch December 27, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants