Automatically downloads contents of onedrive folder

[aaronsuydam]

Description

I store my downloads folder in OneDrive. When I navigate to the folder using Files, it opens and then begins to download all the files in my downloads that have been removed from my device to save space (the "files-on-demand" functionality of OneDrive). This poses a major problem because I have very large files that I download, to keep them all on my device is not possible. I'd be happy to provide logs or something if someone wants to tell me where to look and what sections would be helpful.

Steps To Reproduce

1. Change download folder's location to a path in OneDrive.
2. Populate that folder and then allow OneDrive to automatically free up space.
3. Navigate to the folder using Files.

Requirements

The folder should open and be fully interactable (sort by date/name, scroll, etc) without downloading any files.

Files Version

3.0.15.0

Windows Version

10.0.22621.2715

Log File

debug.log

[yaira2]

Do you have the option to calculate folder sizes turned on?

[yaira2]

Can you also clarify

1. Is files on demand turned on or off?
2. Are there any exe files in this location?
3. Does this happen for every location, or only some locations?
4. Are the files fully online, or are they partially synced?

[NightmareZero]

Can you also clarify

1. Is files on demand turned on or off?
2. Are there any exe files in this location?
3. Does this happen for every location, or only some locations?
4. Are the files fully online, or are they partially synced?

I encountered the same problem.

1. on demand is on
2. no exe in this location
3. in some localtion
4. partially synced, and there is always a re-download some files when I perform 'free up space'.

[yaira2]

@NightmareZero which version of Files are you using? Can you confirm if this happens in all OneDrive locations or is it only some of them?

[NightmareZero]

@NightmareZero which version of Files are you using? Can you confirm if this happens in all OneDrive locations or is it only some of them?

If that directory has an exe file, it will occur at any location
If there is no exe file, it will occur in certain specific directories, but I have not found any pattern

The latest version I am using is from the Windows App Store, and the version is 3.0.15.0， windows version 10.0.22631.2861

[yaira2]

Are there any folders in those locations?

[aaronsuydam]

Can you also clarify

1. Is files on demand turned on or off?

2. Are there any exe files in this location?

3. Does this happen for every location, or only some locations?

4. Are the files fully online, or are they partially synced?

Hey @yaira2 im so sorry, with finals and everything this got lost.

In order, 0. No i do not have calculate folder sizes turned on.

1. Files on Demand is turned on.
2. Yes, many. It is my cloud repository of software packages. I keep the folder in onedrive so that if i run into a situation where i have to re download an obscure piece of software (as happens from time to time), I don't suffer through a server that has the bandwidth of yesteryear.
3. It happens specifically with this location.
4. Some files are online, some are on device. It only starts downloading the ones that are not yet on device.

[NightmareZero]

Are there any folders in those locations?

Yes, there are some other directories

[mbartlett21]

It happens for me when I have 'Show alternate data streams' turned on. Turning off stops it downloading.
(Under Settings > Folders > Hidden items)

EDIT:
It looks like getting alternate data streams opens the file for reading:

Files/src/Files.App/Helpers/Interop/NativeFileOperationsHelper.cs

Lines 529 to 531 in bc00d61

	public static IEnumerable<(string Name, long Size)> GetAlternateStreams(string path)
	{
	using var handle = OpenFileForRead(path);

(executing dir /R seems to use some other way of checking for alternate data streams, as it doesn't make OneDrive download the files)

EDIT2:
https://stackoverflow.com/a/7988352 suggests using FindFirstStreamW and FindNextStreamW from the C API.

Code from the answer (from a old MSDN article)

[SecurityPermission(SecurityAction.LinkDemand, UnmanagedCode = true)]
public sealed class SafeFindHandle : SafeHandleZeroOrMinusOneIsInvalid {

    private SafeFindHandle() : base(true) { }

    protected override bool ReleaseHandle() {
        return FindClose(this.handle);
    }

    [DllImport("kernel32.dll")]
    [return: MarshalAs(UnmanagedType.Bool)]
    [ReliabilityContract(Consistency.WillNotCorruptState, Cer.Success)]
    private static extern bool FindClose(IntPtr handle);

}

public class FileStreamSearcher {
    private const int ERROR_HANDLE_EOF = 38;
    private enum StreamInfoLevels { FindStreamInfoStandard = 0 }

    [DllImport("kernel32.dll", ExactSpelling = true, CharSet = CharSet.Auto, SetLastError = true)]
    private static extern SafeFindHandle FindFirstStreamW(string lpFileName, StreamInfoLevels InfoLevel, [In, Out, MarshalAs(UnmanagedType.LPStruct)] WIN32_FIND_STREAM_DATA lpFindStreamData, uint dwFlags);

    [DllImport("kernel32.dll", ExactSpelling = true, CharSet = CharSet.Auto, SetLastError = true)] [return: MarshalAs(UnmanagedType.Bool)] private static extern bool FindNextStreamW(SafeFindHandle hndFindFile, [In, Out, MarshalAs(UnmanagedType.LPStruct)] WIN32_FIND_STREAM_DATA lpFindStreamData);
    [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
    private class WIN32_FIND_STREAM_DATA {
        public long StreamSize;
        [MarshalAs(UnmanagedType.ByValTStr, SizeConst = 296)]
        public string cStreamName;
    }

    public static IEnumerable<string> GetStreams(FileInfo file) {
        if (file == null) throw new ArgumentNullException("file");
        WIN32_FIND_STREAM_DATA findStreamData = new WIN32_FIND_STREAM_DATA();
        SafeFindHandle handle = FindFirstStreamW(file.FullName, StreamInfoLevels.FindStreamInfoStandard, findStreamData, 0);
        if (handle.IsInvalid) throw new Win32Exception();
        try {
            do {
                yield return findStreamData.cStreamName;
            } while (FindNextStreamW(handle, findStreamData));
            int lastError = Marshal.GetLastWin32Error();
            if (lastError != ERROR_HANDLE_EOF) throw new Win32Exception(lastError);
        } finally {
            handle.Dispose();
        }
    }
}

[yaira2]

@aaronsuydam @NightmareZero can you confirm if that's the case for you as well?

[aaronsuydam]

@yaira2 it is not the case for me. Just checked, and on a fresh install of the app this morning from the MS store.

[mbartlett21]

@mbartlett21 would you be interested in working on a fix?

@yaira2
Fix for alternate data streams done, tested and PR: #14398