Skip to content

Commit eb38f9e

Browse files
authored
Feature: Show a tooltip when a text in the details view is trimmed (#12488)
1 parent 61b4128 commit eb38f9e

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -634,6 +634,7 @@
634634
<TextBlock
635635
x:Name="ItemName"
636636
VerticalAlignment="Center"
637+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
637638
Opacity="{x:Bind Opacity, Mode=OneWay}"
638639
Text="{x:Bind Name, Mode=OneWay}"
639640
TextTrimming="CharacterEllipsis" />
@@ -720,6 +721,7 @@
720721
HorizontalAlignment="Stretch"
721722
VerticalAlignment="Center"
722723
x:Load="{x:Bind IsRecycleBinItem}"
724+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
723725
Style="{StaticResource ColumnContentTextBlock}"
724726
Text="{x:Bind AsRecycleBinItem.ItemOriginalPath, Mode=OneWay}"
725727
Visibility="{Binding ColumnsViewModel.OriginalPathColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
@@ -731,6 +733,7 @@
731733
HorizontalAlignment="Stretch"
732734
VerticalAlignment="Center"
733735
x:Load="{x:Bind IsRecycleBinItem}"
736+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
734737
Style="{StaticResource ColumnContentTextBlock}"
735738
Text="{x:Bind AsRecycleBinItem.ItemDateDeleted, Mode=OneWay}"
736739
Visibility="{Binding ColumnsViewModel.DateDeletedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
@@ -741,6 +744,7 @@
741744
Padding="12,0,0,0"
742745
HorizontalAlignment="Stretch"
743746
VerticalAlignment="Center"
747+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
744748
Style="{StaticResource ColumnContentTextBlock}"
745749
Text="{x:Bind ItemDateModified, Mode=OneWay}"
746750
Visibility="{Binding ColumnsViewModel.DateModifiedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
@@ -751,6 +755,7 @@
751755
Padding="12,0,0,0"
752756
HorizontalAlignment="Stretch"
753757
VerticalAlignment="Center"
758+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
754759
Style="{StaticResource ColumnContentTextBlock}"
755760
Text="{x:Bind ItemDateCreated, Mode=OneWay}"
756761
Visibility="{Binding ColumnsViewModel.DateCreatedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
@@ -761,6 +766,7 @@
761766
Padding="12,0,0,0"
762767
HorizontalAlignment="Stretch"
763768
VerticalAlignment="Center"
769+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
764770
Style="{StaticResource ColumnContentTextBlock}"
765771
Text="{x:Bind ItemType, Mode=OneWay}"
766772
Visibility="{Binding ColumnsViewModel.ItemTypeColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
@@ -771,6 +777,7 @@
771777
Padding="12,0,0,0"
772778
HorizontalAlignment="Stretch"
773779
VerticalAlignment="Center"
780+
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
774781
Style="{StaticResource ColumnContentTextBlock}"
775782
Text="{x:Bind FileSize, Mode=OneWay}"
776783
Visibility="{Binding ColumnsViewModel.SizeColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />

src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -804,5 +804,11 @@ private void UpdateCheckboxVisibility(object sender, bool isPointerOver)
804804
VisualStateManager.GoToState(userControl, "HideCheckbox", true);
805805
}
806806
}
807+
808+
// Workaround for https://github.com/microsoft/microsoft-ui-xaml/issues/170
809+
private void TextBlock_IsTextTrimmedChanged(TextBlock sender, IsTextTrimmedChangedEventArgs e)
810+
{
811+
ToolTipService.SetToolTip(sender, sender.IsTextTrimmed ? sender.Text : null);
812+
}
807813
}
808814
}

0 commit comments

Comments
 (0)