Code Quality: Fixed semaphore release timing in ItemViewModel (#14619)

Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>

Author: hishitetsu

src/Files.App/Data/Models/ItemViewModel.cs

@@ -689,6 +689,7 @@ void ClearDisplay()
 				// we have to call BeginBulkOperation to suppress CollectionChanged and call EndBulkOperation
 				// in the end to fire a CollectionChanged event with NotifyCollectionChangedAction.Reset
 				await bulkOperationSemaphore.WaitAsync(addFilesCTS.Token);
+				var isSemaphoreReleased = false;
 				try
 				{
 					FilesAndFolders.BeginBulkOperation();
@@ -710,11 +711,19 @@ void ApplyChanges()
 
 					void UpdateUI()
 					{
-						// Trigger CollectionChanged with NotifyCollectionChangedAction.Reset
-						// once loading is completed so that UI can be updated
-						FilesAndFolders.EndBulkOperation();
-						UpdateEmptyTextType();
-						DirectoryInfoUpdated?.Invoke(this, EventArgs.Empty);
+						try
+						{
+							// Trigger CollectionChanged with NotifyCollectionChangedAction.Reset
+							// once loading is completed so that UI can be updated
+							FilesAndFolders.EndBulkOperation();
+							UpdateEmptyTextType();
+							DirectoryInfoUpdated?.Invoke(this, EventArgs.Empty);
+						}
+						finally
+						{
+							isSemaphoreReleased = true;
+							bulkOperationSemaphore.Release();
+						}
 					}
 
 					if (NativeWinApiHelper.IsHasThreadAccessPropertyPresent && dispatcherQueue.HasThreadAccess)
@@ -726,11 +735,15 @@ void UpdateUI()
 					{
 						ApplyChanges();
 						await dispatcherQueue.EnqueueOrInvokeAsync(UpdateUI);
+
+						// The semaphore will be released in UI thread
+						isSemaphoreReleased = true;
 					}
 				}
 				finally
 				{
-					bulkOperationSemaphore.Release();
+					if (!isSemaphoreReleased)
+						bulkOperationSemaphore.Release();
 				}
 			}
 			catch (Exception ex)
@@ -830,6 +843,7 @@ public async Task GroupOptionsUpdatedAsync(CancellationToken token)
 			try
 			{
 				await bulkOperationSemaphore.WaitAsync(token);
+				var isSemaphoreReleased = false;
 				try
 				{
 					FilesAndFolders.BeginBulkOperation();
@@ -854,12 +868,26 @@ await Task.Run(() =>
 					if (token.IsCancellationRequested)
 						return;
 
-					await dispatcherQueue.EnqueueOrInvokeAsync(
-						FilesAndFolders.EndBulkOperation);
+					await dispatcherQueue.EnqueueOrInvokeAsync(() =>
+					{
+						try
+						{
+							FilesAndFolders.EndBulkOperation();
+						}
+						finally
+						{
+							isSemaphoreReleased = true;
+							bulkOperationSemaphore.Release();
+						}
+					});
+
+					// The semaphore will be released in UI thread
+					isSemaphoreReleased = true;
 				}
 				finally
 				{
-					bulkOperationSemaphore.Release();
+					if (!isSemaphoreReleased)
+						bulkOperationSemaphore.Release();
 				}
 			}
 			catch (Exception ex)