Skip to content

Commit dda657d

Browse files
authored
Code Quality: Avoid redundant OnPropertyChanged calls in ContentPageContext (#14114)
1 parent 1109b1d commit dda657d

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

src/Files.App/Data/Contexts/ContentPage/ContentPageContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ private void Context_Changed(object? sender, EventArgs e)
107107

108108
Update();
109109
OnPropertyChanged(nameof(ShellPage));
110+
OnPropertyChanged(nameof(Folder));
110111
}
111112

112113
private void Page_PropertyChanged(object? sender, PropertyChangedEventArgs e)
@@ -196,7 +197,6 @@ private void Update()
196197
UpdatePageType();
197198
UpdateSelectedItems();
198199

199-
OnPropertyChanged(nameof(Folder));
200200
OnPropertyChanged(nameof(HasItem));
201201
OnPropertyChanged(nameof(CanGoBack));
202202
OnPropertyChanged(nameof(CanGoForward));

src/Files.App/Data/Contexts/Page/PageContext.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ private void UpdatePage(PaneHolderPage? newPage)
7575

7676
private void UpdateContent()
7777
{
78+
if (pane == page?.ActivePane && paneOrColumn == page?.ActivePaneOrColumn)
79+
return;
80+
7881
Changing?.Invoke(this, EventArgs.Empty);
7982

8083
pane = page?.ActivePane;

src/Files.App/Views/MainPage.xaml.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,9 @@ private void LoadPaneChanged()
461461
private void OnPropertyChanged([CallerMemberName] string propertyName = "")
462462
{
463463
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
464+
465+
if (propertyName == nameof(ShouldPreviewPaneBeActive) && ShouldPreviewPaneBeActive)
466+
_ = Ioc.Default.GetRequiredService<InfoPaneViewModel>().UpdateSelectedItemPreviewAsync();
464467
}
465468

466469
private void RootGrid_PreviewKeyDown(object sender, KeyRoutedEventArgs e)

0 commit comments

Comments
 (0)