Code Quality: Use volatile for isMainWindowClosed (#14659)

hishitetsu · web-flow · commit db1afa94dc58 · 2024-02-06T18:24:53.000-08:00
diff --git a/src/Files.App/Data/Models/AppModel.cs b/src/Files.App/Data/Models/AppModel.cs
@@ -58,11 +58,16 @@ public bool IsPasteEnabled
 			set => SetProperty(ref isPasteEnabled, value);
 		}
 
-		private bool isMainWindowClosed = false;
+		private volatile int isMainWindowClosed = 0;
 		public bool IsMainWindowClosed
 		{
-			get => isMainWindowClosed;
-			set => SetProperty(ref isMainWindowClosed, value);
+			get => isMainWindowClosed == 1;
+			set
+			{
+				int orig = Interlocked.Exchange(ref isMainWindowClosed, value ? 1 : 0);
+				if (isMainWindowClosed != orig)
+					OnPropertyChanged();
+			}
 		}
 
 		private int propertiesWindowCount = 0;

Original file line number	Diff line number	Diff line change
`@@ -58,11 +58,16 @@ public bool IsPasteEnabled`
`58`	`58`	`set => SetProperty(ref isPasteEnabled, value);`
`59`	`59`	`}`
`60`	`60`
`61`		`- private bool isMainWindowClosed = false;`
	`61`	`+ private volatile int isMainWindowClosed = 0;`
`62`	`62`	`public bool IsMainWindowClosed`
`63`	`63`	`{`
`64`		`- get => isMainWindowClosed;`
`65`		`- set => SetProperty(ref isMainWindowClosed, value);`
	`64`	`+ get => isMainWindowClosed == 1;`
	`65`	`+ set`
	`66`	`+ {`
	`67`	`+ int orig = Interlocked.Exchange(ref isMainWindowClosed, value ? 1 : 0);`
	`68`	`+ if (isMainWindowClosed != orig)`
	`69`	`+ OnPropertyChanged();`
	`70`	`+ }`
`66`	`71`	`}`
`67`	`72`
`68`	`73`	`private int propertiesWindowCount = 0;`