Fix MoveToTop and MoveToBottom not working

Author: gave92

src/Files.Uwp/DataModels/SidebarPinnedModel.cs

@@ -145,10 +145,12 @@ public bool MoveItem(INavigationControlItem locationItem, int oldIndex, int newI
 
             try
             {
-                (FavoriteItems[oldIndex], FavoriteItems[newIndex]) = (FavoriteItems[newIndex], FavoriteItems[oldIndex]);
+                FavoriteItems.RemoveAt(oldIndex);
+                FavoriteItems.Insert(newIndex, locationItem.Path);
                 lock (favoriteList)
                 {
-                    (favoriteList[oldIndex], favoriteList[newIndex]) = (favoriteList[newIndex], favoriteList[oldIndex]);
+                    favoriteList.RemoveAt(oldIndex);
+                    favoriteList.Insert(newIndex, locationItem);
                 }
                 var e = new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Move, locationItem, newIndex, oldIndex);
                 controller.DataChanged?.Invoke(SectionType.Favorites, e);

src/Files.Uwp/UserControls/SidebarControl.xaml.cs

@@ -392,7 +392,7 @@ private void MoveItemToTop()
                 }
 
                 int oldIndex = App.SidebarPinnedController.Model.IndexOfItem(rightClickedItem);
-                App.SidebarPinnedController.Model.MoveItem(rightClickedItem, oldIndex, 1);
+                App.SidebarPinnedController.Model.MoveItem(rightClickedItem, oldIndex, 0);
 
                 if (isSelectedSidebarItem)
                 {
@@ -455,7 +455,7 @@ private void MoveItemToBottom()
                 }
 
                 int oldIndex = App.SidebarPinnedController.Model.IndexOfItem(rightClickedItem);
-                App.SidebarPinnedController.Model.MoveItem(rightClickedItem, oldIndex, App.SidebarPinnedController.Model.FavoriteItems.Count);
+                App.SidebarPinnedController.Model.MoveItem(rightClickedItem, oldIndex, App.SidebarPinnedController.Model.FavoriteItems.Count - 1);
 
                 if (isSelectedSidebarItem)
                 {