Fix: Fixed crash when Git branch tip is null (#12622)

tanchekwei · web-flow · commit 8293169a4ba1 · 2023-06-15T11:11:10.000-04:00
diff --git a/src/Files.App/Helpers/GitHelpers.cs b/src/Files.App/Helpers/GitHelpers.cs
@@ -83,7 +83,7 @@ public static BranchItem[] GetBranchesNames(string? path)
 				.Where(b => !b.IsRemote || b.RemoteName == "origin")
 				.OrderByDescending(b => b.IsCurrentRepositoryHead)
 				.ThenBy(b => b.IsRemote)
-				.ThenByDescending(b => b.Tip.Committer.When)
+				.ThenByDescending(b => b.Tip?.Committer.When)
 				.Select(b => new BranchItem(b.FriendlyName, b.IsRemote, b.TrackingDetails.AheadBy, b.TrackingDetails.BehindBy))
 				.ToArray();
 		}

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public static BranchItem[] GetBranchesNames(string? path)`
`83`	`83`	`.Where(b => !b.IsRemote \|\| b.RemoteName == "origin")`
`84`	`84`	`.OrderByDescending(b => b.IsCurrentRepositoryHead)`
`85`	`85`	`.ThenBy(b => b.IsRemote)`
`86`		`- .ThenByDescending(b => b.Tip.Committer.When)`
	`86`	`+ .ThenByDescending(b => b.Tip?.Committer.When)`
`87`	`87`	`.Select(b => new BranchItem(b.FriendlyName, b.IsRemote, b.TrackingDetails.AheadBy, b.TrackingDetails.BehindBy))`
`88`	`88`	`.ToArray();`
`89`	`89`	`}`