Skip to content

Commit 7d21904

Browse files
authored
Removed extra controls from visual tree (#7949)
1 parent 83f4a02 commit 7d21904

File tree

3 files changed

+53
-58
lines changed

3 files changed

+53
-58
lines changed

src/Files/UserControls/InnerNavigationToolbar.xaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
<x:Boolean x:Key="True">True</x:Boolean>
3030
<x:Boolean x:Key="False">False</x:Boolean>
3131
<ResourceDictionary.MergedDictionaries>
32-
<ResourceDictionary Source="/ResourceDictionaries/ToolbarButtonStyle.xaml" />
3332
<ResourceDictionary Source="/ResourceDictionaries/PathIcons.xaml" />
3433
<ResourceDictionary Source="/ResourceDictionaries/RightAlignedToggleSwitchStyle.xaml" />
3534
</ResourceDictionary.MergedDictionaries>

src/Files/UserControls/NavigationToolbar.xaml

Lines changed: 46 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -514,54 +514,52 @@
514514
</Button.KeyboardAccelerators>
515515
</Button>
516516

517-
<Grid x:Name="OngoingTasksGrid" Visibility="{x:Bind OngoingTasksViewModel.AnyBannersPresent, Mode=OneWay}">
518-
<Button
519-
x:Name="OngoingTasks"
520-
Width="36"
521-
Height="32"
522-
Padding="0"
523-
AccessKey="T"
524-
AutomationProperties.Name="{helpers:ResourceString Name=OngoingTasks}"
525-
Background="Transparent"
526-
Style="{StaticResource ToolBarButtonStyle}"
527-
ToolTipService.ToolTip="{helpers:ResourceString Name=OngoingTasks}"
528-
Visibility="Visible">
529-
<Button.Content>
530-
<Grid>
531-
<FontIcon
532-
x:Name="OngoingTasksFontIcon"
533-
FontSize="16"
534-
Glyph="&#xF16A;" />
535-
<muxc:ProgressRing
536-
x:Name="MedianOperationProgressRing"
537-
Width="28"
538-
Height="28"
539-
HorizontalAlignment="Center"
540-
VerticalAlignment="Center"
541-
x:Load="{x:Bind OngoingTasksViewModel.AnyOperationsOngoing, Mode=OneWay}"
542-
IsIndeterminate="False"
543-
Value="{x:Bind OngoingTasksViewModel.MedianOperationProgressValue, Mode=OneWay}" />
544-
</Grid>
545-
</Button.Content>
546-
<Button.Flyout>
547-
<Flyout contract8Present:ShouldConstrainToRootBounds="False" AutomationProperties.Name="{helpers:ResourceString Name=OngoingTasks}">
548-
<uc:OngoingTasksFlyout
549-
x:Name="OngoingTasksControl"
550-
Width="300"
551-
MinHeight="300"
552-
MaxHeight="400"
553-
x:FieldModifier="public"
554-
IsTabStop="True"
555-
OngoingTasksViewModel="{x:Bind OngoingTasksViewModel}" />
556-
</Flyout>
557-
</Button.Flyout>
558-
</Button>
559-
<muxc:InfoBadge
560-
x:Name="StatusInfoBadge"
561-
HorizontalAlignment="Right"
562-
VerticalAlignment="Top"
563-
Value="{x:Bind OngoingTasksViewModel.InfoBadgeValue, Mode=OneWay}" />
564-
</Grid>
517+
<Button
518+
x:Name="OngoingTasks"
519+
Width="36"
520+
Height="32"
521+
Padding="0"
522+
AccessKey="T"
523+
AutomationProperties.Name="{helpers:ResourceString Name=OngoingTasks}"
524+
Background="Transparent"
525+
Style="{StaticResource ToolBarButtonStyle}"
526+
ToolTipService.ToolTip="{helpers:ResourceString Name=OngoingTasks}"
527+
Visibility="{x:Bind OngoingTasksViewModel.AnyBannersPresent, Mode=OneWay}">
528+
<Button.Content>
529+
<Grid>
530+
<FontIcon
531+
x:Name="OngoingTasksFontIcon"
532+
FontSize="16"
533+
Glyph="&#xF16A;" />
534+
<muxc:ProgressRing
535+
x:Name="MedianOperationProgressRing"
536+
Width="28"
537+
Height="28"
538+
HorizontalAlignment="Center"
539+
VerticalAlignment="Center"
540+
x:Load="{x:Bind OngoingTasksViewModel.AnyOperationsOngoing, Mode=OneWay}"
541+
IsIndeterminate="False"
542+
Value="{x:Bind OngoingTasksViewModel.MedianOperationProgressValue, Mode=OneWay}" />
543+
</Grid>
544+
</Button.Content>
545+
<Button.Flyout>
546+
<Flyout contract8Present:ShouldConstrainToRootBounds="False" AutomationProperties.Name="{helpers:ResourceString Name=OngoingTasks}">
547+
<uc:OngoingTasksFlyout
548+
x:Name="OngoingTasksControl"
549+
Width="300"
550+
MinHeight="300"
551+
MaxHeight="400"
552+
x:FieldModifier="public"
553+
IsTabStop="True"
554+
OngoingTasksViewModel="{x:Bind OngoingTasksViewModel}" />
555+
</Flyout>
556+
</Button.Flyout>
557+
</Button>
558+
<muxc:InfoBadge
559+
x:Name="StatusInfoBadge"
560+
HorizontalAlignment="Right"
561+
VerticalAlignment="Top"
562+
Value="{x:Bind OngoingTasksViewModel.InfoBadgeValue, Mode=OneWay}" />
565563

566564
<Button
567565
x:Name="SettingsButton"

src/Files/Views/PaneHolderPage.xaml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,13 @@
5353
MinWidth="0" />
5454
</Grid.ColumnDefinitions>
5555

56-
<Border x:Name="PaneLeftBorder">
57-
<local:ModernShellPage
58-
x:Name="PaneLeft"
59-
ContentChanged="Pane_ContentChanged"
60-
IsPageMainPane="True"
61-
Loaded="PaneLeft_Loaded"
62-
NavParams="{x:Bind NavParamsLeft, Mode=OneWay}"
63-
PaneHolder="{x:Bind}" />
64-
</Border>
56+
<local:ModernShellPage
57+
x:Name="PaneLeft"
58+
ContentChanged="Pane_ContentChanged"
59+
IsPageMainPane="True"
60+
Loaded="PaneLeft_Loaded"
61+
NavParams="{x:Bind NavParamsLeft, Mode=OneWay}"
62+
PaneHolder="{x:Bind}" />
6563

6664
<Border
6765
x:Name="PaneRightBorder"

0 commit comments

Comments
 (0)