Skip to content

Commit 74cfb6b

Browse files
authored
Fix: Fixed issue where widths of Git columns were not set correctly (#12732)
1 parent 55e51ff commit 74cfb6b

File tree

3 files changed

+36
-6
lines changed

3 files changed

+36
-6
lines changed

src/Files.App/Data/Models/ColumnsViewModel.cs

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,11 @@ public ColumnViewModel SizeColumn
133133
[LiteDB.BsonIgnore]
134134
public double TotalWidth =>
135135
IconColumn.Length.Value +
136+
GitStatusColumn.Length.Value +
137+
GitLastCommitDateColumn.Length.Value +
138+
GitLastCommitMessageColumn.Length.Value +
139+
GitCommitAuthorColumn.Length.Value +
140+
GitLastCommitShaColumn.Length.Value +
136141
TagColumn.Length.Value +
137142
NameColumn.Length.Value +
138143
DateModifiedColumn.Length.Value +
@@ -160,6 +165,11 @@ public void SetDesiredSize(double width)
160165
private void SetColumnSizeProportionally(double factor)
161166
{
162167
NameColumn.TryMultiplySize(factor);
168+
GitStatusColumn.TryMultiplySize(factor);
169+
GitLastCommitDateColumn.TryMultiplySize(factor);
170+
GitLastCommitMessageColumn.TryMultiplySize(factor);
171+
GitCommitAuthorColumn.TryMultiplySize(factor);
172+
GitLastCommitShaColumn.TryMultiplySize(factor);
163173
TagColumn.TryMultiplySize(factor);
164174
DateModifiedColumn.TryMultiplySize(factor);
165175
OriginalPathColumn.TryMultiplySize(factor);
@@ -189,7 +199,12 @@ public override bool Equals(object? obj)
189199
model.OriginalPathColumn.Equals(OriginalPathColumn) &&
190200
model.SizeColumn.Equals(SizeColumn) &&
191201
model.StatusColumn.Equals(StatusColumn) &&
192-
model.TagColumn.Equals(TagColumn);
202+
model.TagColumn.Equals(TagColumn) &&
203+
model.GitStatusColumn.Equals(GitStatusColumn) &&
204+
model.GitLastCommitDateColumn.Equals(GitLastCommitDateColumn) &&
205+
model.GitLastCommitMessageColumn.Equals(GitLastCommitMessageColumn) &&
206+
model.GitCommitAuthorColumn.Equals(GitCommitAuthorColumn) &&
207+
model.GitLastCommitShaColumn.Equals(GitLastCommitShaColumn);
193208
}
194209

195210
return base.Equals(obj);
@@ -206,6 +221,11 @@ public override int GetHashCode()
206221
hashCode = (hashCode * 397) ^ SizeColumn.GetHashCode();
207222
hashCode = (hashCode * 397) ^ StatusColumn.GetHashCode();
208223
hashCode = (hashCode * 397) ^ TagColumn.GetHashCode();
224+
hashCode = (hashCode * 397) ^ GitStatusColumn.GetHashCode();
225+
hashCode = (hashCode * 397) ^ GitLastCommitDateColumn.GetHashCode();
226+
hashCode = (hashCode * 397) ^ GitLastCommitMessageColumn.GetHashCode();
227+
hashCode = (hashCode * 397) ^ GitCommitAuthorColumn.GetHashCode();
228+
hashCode = (hashCode * 397) ^ GitLastCommitShaColumn.GetHashCode();
209229

210230
return hashCode;
211231
}

src/Files.App/Helpers/LayoutPreferences/LayoutPreferences.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ public LayoutPreferences()
5656
ColumnsViewModel.DateCreatedColumn.UserLengthPixels = UserSettingsService.FoldersSettingsService.DateCreatedColumnWidth;
5757
ColumnsViewModel.ItemTypeColumn.UserLengthPixels = UserSettingsService.FoldersSettingsService.TypeColumnWidth;
5858
ColumnsViewModel.SizeColumn.UserLengthPixels = UserSettingsService.FoldersSettingsService.SizeColumnWidth;
59-
ColumnsViewModel.GitStatusColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.SizeColumnWidth;
60-
ColumnsViewModel.GitLastCommitDateColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.SizeColumnWidth;
61-
ColumnsViewModel.GitLastCommitMessageColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.SizeColumnWidth;
62-
ColumnsViewModel.GitCommitAuthorColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.SizeColumnWidth;
63-
ColumnsViewModel.GitLastCommitShaColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.SizeColumnWidth;
59+
ColumnsViewModel.GitStatusColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.GitStatusColumnWidth;
60+
ColumnsViewModel.GitLastCommitDateColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.GitLastCommitDateColumnWidth;
61+
ColumnsViewModel.GitLastCommitMessageColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.GitLastCommitMessageColumnWidth;
62+
ColumnsViewModel.GitCommitAuthorColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.GitCommitAuthorColumnWidth;
63+
ColumnsViewModel.GitLastCommitShaColumn.UserLengthPixels= UserSettingsService.FoldersSettingsService.GitLastCommitShaColumnWidth;
6464
ColumnsViewModel.TagColumn.UserLengthPixels = UserSettingsService.FoldersSettingsService.TagColumnWidth;
6565
ColumnsViewModel.DateDeletedColumn.UserLengthPixels = UserSettingsService.FoldersSettingsService.DateDeletedColumnWidth;
6666
ColumnsViewModel.OriginalPathColumn.UserLengthPixels = UserSettingsService.FoldersSettingsService.OriginalPathColumnWidth;

src/Files.App/Services/Settings/FoldersSettingsService.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,11 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
373373
{
374374
case nameof(SyncFolderPreferencesAcrossDirectories):
375375
case nameof(DefaultLayoutMode):
376+
case nameof(GitStatusColumnWidth):
377+
case nameof(GitLastCommitDateColumnWidth):
378+
case nameof(GitLastCommitMessageColumnWidth):
379+
case nameof(GitCommitAuthorColumnWidth):
380+
case nameof(GitLastCommitShaColumnWidth):
376381
case nameof(TagColumnWidth):
377382
case nameof(NameColumnWidth):
378383
case nameof(DateModifiedColumnWidth):
@@ -383,6 +388,11 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
383388
case nameof(ShowDateCreatedColumn):
384389
case nameof(ShowTypeColumn):
385390
case nameof(ShowSizeColumn):
391+
case nameof(ShowGitStatusColumn):
392+
case nameof(ShowGitLastCommitDateColumn):
393+
case nameof(ShowGitLastCommitMessageColumn):
394+
case nameof(ShowGitCommitAuthorColumn):
395+
case nameof(ShowGitLastCommitShaColumn):
386396
case nameof(ShowFileTagColumn):
387397
case nameof(ShowHiddenItems):
388398
case nameof(ShowProtectedSystemFiles):

0 commit comments

Comments
 (0)