Skip to content

Commit 5fcb7e3

Browse files
Feature: Delay loading Properties button until details are finished loading (#12971)
1 parent 9c4660d commit 5fcb7e3

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/Files.App/UserControls/Pane/PreviewPane.xaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,8 @@
336336
HorizontalAlignment="Left"
337337
Command="{x:Bind Commands.OpenProperties}"
338338
IsEnabled="{x:Bind Commands.OpenProperties.IsExecutable, Mode=OneWay}"
339-
ToolTipService.ToolTip="{x:Bind Commands.OpenProperties.LabelWithHotKey, Mode=OneWay}">
339+
ToolTipService.ToolTip="{x:Bind Commands.OpenProperties.LabelWithHotKey, Mode=OneWay}"
340+
Visibility="Collapsed">
340341
<Button.Content>
341342
<StackPanel Orientation="Horizontal" Spacing="8">
342343
<usercontrols:OpacityIcon Style="{x:Bind Commands.OpenProperties.OpacityStyle}" />
@@ -364,6 +365,7 @@
364365
<Setter Target="PreviewErrorText.Text" Value="{x:Bind GetLocalizedResource('DetailsPanePreviewNotAvaliableText')}" />
365366
<Setter Target="FileDetailsRepeater.Visibility" Value="Visible" />
366367
<Setter Target="DetailsEditTags.Visibility" Value="Visible" />
368+
<Setter Target="DetailsOpenProperties.Visibility" Value="Visible" />
367369
<Setter Target="DetailsListHeader.Visibility" Value="Visible" />
368370
<Setter Target="PreviewControlPresenter.Visibility" Value="Collapsed" />
369371
</VisualState.Setters>
@@ -377,6 +379,7 @@
377379
<Setter Target="PreviewErrorText.Text" Value="{x:Bind GetLocalizedResource('DetailsPanePreviewNotAvaliableText')}" />
378380
<Setter Target="FileDetailsRepeater.Visibility" Value="Collapsed" />
379381
<Setter Target="DetailsEditTags.Visibility" Value="Collapsed" />
382+
<Setter Target="DetailsOpenProperties.Visibility" Value="Collapsed" />
380383
<Setter Target="PreviewControlPresenter.Visibility" Value="Collapsed" />
381384
</VisualState.Setters>
382385
</VisualState>
@@ -388,6 +391,7 @@
388391
<Setter Target="PreviewErrorText.Visibility" Value="Collapsed" />
389392
<Setter Target="FileDetailsRepeater.Visibility" Value="Visible" />
390393
<Setter Target="DetailsEditTags.Visibility" Value="Visible" />
394+
<Setter Target="DetailsOpenProperties.Visibility" Value="Visible" />
391395
<Setter Target="PreviewControlPresenter.Visibility" Value="Visible" />
392396
<Setter Target="DetailsListHeader.Visibility" Value="Visible" />
393397
</VisualState.Setters>
@@ -400,6 +404,7 @@
400404
<Setter Target="PreviewErrorText.Visibility" Value="Collapsed" />
401405
<Setter Target="FileDetailsRepeater.Visibility" Value="Collapsed" />
402406
<Setter Target="DetailsEditTags.Visibility" Value="Collapsed" />
407+
<Setter Target="DetailsOpenProperties.Visibility" Value="Collapsed" />
403408
<Setter Target="DetailsListHeader.Visibility" Value="Visible" />
404409
<Setter Target="PreviewControlPresenter.Visibility" Value="Collapsed" />
405410
<Setter Target="PreviewLoadingIndicator.Visibility" Value="Visible" />

0 commit comments

Comments
 (0)