Skip to content

Commit 511daff

Browse files
authored
Code Quality: Remove embedded Package.appinstaller (#14908)
1 parent bda0057 commit 511daff

File tree

4 files changed

+18
-16
lines changed

4 files changed

+18
-16
lines changed

.github/workflows/deploy-preview.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,14 @@ jobs:
131131
shell: bash
132132
run: find $ARTIFACTS_STAGING_DIR -empty -delete
133133

134+
- name: Update appinstaller schema
135+
run: |
136+
$newSchema = "http://schemas.microsoft.com/appx/appinstaller/2018"
137+
$localFilePath = "${{ env.APPX_PACKAGE_DIR }}/Files.Package.appinstaller"
138+
$fileContent = Get-Content $localFilePath
139+
$fileContent = $fileContent.Replace("http://schemas.microsoft.com/appx/appinstaller/2017/2", $newSchema)
140+
$fileContent | Set-Content $localFilePath
141+
134142
- name: Sign files with Azure Code Signing
135143
uses: azure/azure-code-signing-action@v0.2.21
136144
with:
@@ -163,7 +171,7 @@ jobs:
163171
- name: logout
164172
run: |
165173
az logout
166-
174+
167175
- name: Upload the packages to GitHub Actions
168176
uses: actions/upload-artifact@v3
169177
with:

.github/workflows/deploy-stable.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,14 @@ jobs:
131131
shell: bash
132132
run: find $ARTIFACTS_STAGING_DIR -empty -delete
133133

134+
- name: Update appinstaller schema
135+
run: |
136+
$newSchema = "http://schemas.microsoft.com/appx/appinstaller/2018"
137+
$localFilePath = "${{ env.APPX_PACKAGE_DIR }}/Files.Package.appinstaller"
138+
$fileContent = Get-Content $localFilePath
139+
$fileContent = $fileContent.Replace("http://schemas.microsoft.com/appx/appinstaller/2017/2", $newSchema)
140+
$fileContent | Set-Content $localFilePath
141+
134142
- name: Sign files with Azure Code Signing
135143
uses: azure/azure-code-signing-action@v0.2.21
136144
with:

src/Files.App (Package)/Files.Package.wapproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<AppxBundleAutoResourcePackageQualifiers>Scale|DXFeatureLevel</AppxBundleAutoResourcePackageQualifiers>
1717
<AppxDefaultResourceQualifiers>Language=en-US;af;ar;bg;ca;cs-CZ;da;da-DK;de-DE;el;en-GB;es-ES;es-419;fa-IR;fi-FI;fil-PH;fr-FR;he-IL;hi-IN;hu-HU;id-ID;it-IT;ja-JP;ka;ko-KR;lt;lv-LV;nb-NO;nl-NL;or-IN;pl-PL;pt-BR;pt-PT;ro-RO;ru-RU;sk-SK;sv-SE;ta;th-TH;tr-TR;uk-UA;vi;zh-Hans;zh-Hant</AppxDefaultResourceQualifiers>
1818
<UapAppxPackageBuildMode>StoreUpload</UapAppxPackageBuildMode>
19+
<HoursBetweenUpdateChecks>255</HoursBetweenUpdateChecks>
1920
<EntryPointProjectUniqueName>..\Files.App\Files.App.csproj</EntryPointProjectUniqueName>
2021
<AppxBundle>Always</AppxBundle>
2122
</PropertyGroup>
@@ -94,7 +95,6 @@
9495
<SubType>Designer</SubType>
9596
</AppxManifest>
9697
<Content Include="Assets\AppTiles\Dev\**" />
97-
<Content Include="Package.appinstaller" />
9898
</ItemGroup>
9999
<ItemGroup>
100100
<ProjectReference Include="..\Files.App.Server\Files.App.Server.csproj">

src/Files.App (Package)/Package.appinstaller

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)