Skip to content

Commit 471c1a0

Browse files
authored
Code Quality: Move platform-depending classes from Shared to Core (#12874)
1 parent 6fff25f commit 471c1a0

File tree

162 files changed

+730
-447
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

162 files changed

+730
-447
lines changed

Files.sln

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -409,16 +409,16 @@ Global
409409
GlobalSection(NestedProjects) = preSolution
410410
{A188C26B-E731-4E0B-9D17-D21CEBD9B43F} = {A74DCE98-A744-4D71-A2B1-7EE4FED0936B}
411411
{9F36C2AD-005D-4EA5-A1F1-6BC42773FC85} = {A74DCE98-A744-4D71-A2B1-7EE4FED0936B}
412-
{94F77692-D47C-48D8-A1A7-645192EF38A4} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
412+
{94F77692-D47C-48D8-A1A7-645192EF38A4} = {9F36C2AD-005D-4EA5-A1F1-6BC42773FC85}
413413
{B8051E11-5BF2-49F7-A7C8-E3820DBB8209} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
414414
{74704E22-9A09-4675-AE35-7896DE81EC4A} = {9F36C2AD-005D-4EA5-A1F1-6BC42773FC85}
415415
{53371D77-7AC1-4975-9A2A-5E0EB0B37CE3} = {9F36C2AD-005D-4EA5-A1F1-6BC42773FC85}
416-
{BB1DA0B0-4E5B-4336-961E-DF389482C094} = {9F36C2AD-005D-4EA5-A1F1-6BC42773FC85}
416+
{BB1DA0B0-4E5B-4336-961E-DF389482C094} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
417417
{4ED01D20-8529-4DEF-8C1B-4E31031AE7E0} = {481DE2EA-E6CE-4A9C-A220-3B543B95AAA1}
418418
{A2FF3F3B-8EBC-4108-B99D-1476B7876656} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
419419
{25FD5045-6D4C-4DD0-B3AC-613AB59CBB07} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
420420
{6F431D82-A5FF-4833-B5E4-702E1E523126} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
421-
{8F60FD8E-1921-47D6-97B0-D26D7B3A4999} = {9F36C2AD-005D-4EA5-A1F1-6BC42773FC85}
421+
{8F60FD8E-1921-47D6-97B0-D26D7B3A4999} = {A188C26B-E731-4E0B-9D17-D21CEBD9B43F}
422422
{6FA07816-DE0A-4D49-84E8-38E953A33C87} = {9F36C2AD-005D-4EA5-A1F1-6BC42773FC85}
423423
EndGlobalSection
424424
GlobalSection(ExtensibilityGlobals) = postSolution

src/Files.App/App.xaml.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@
2121
using Files.App.ViewModels.Settings;
2222
using Files.Core.Services.SizeProvider;
2323
using Files.Core.Storage;
24+
using Files.Core.Utils.Cloud;
2425
using Files.Shared;
25-
using Files.Shared.Cloud;
26-
using Files.Shared.Services;
27-
using Files.Shared.Services.DateTimeFormatter;
2826
using Microsoft.AppCenter;
2927
using Microsoft.AppCenter.Analytics;
3028
using Microsoft.AppCenter.Crashes;

src/Files.App/Converters/DateTimeOffsetToStringConverter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Services.DateTimeFormatter;
54
using Microsoft.UI.Xaml.Data;
65

76
namespace Files.App.Converters

src/Files.App/Data/Items/ListedItem.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using Files.App.ViewModels.Properties;
77
using Files.Core.Helpers;
88
using Files.Core.ViewModels.FileTags;
9-
using Files.Shared.Services.DateTimeFormatter;
109
using FluentFTP;
1110
using Microsoft.UI;
1211
using Microsoft.UI.Xaml;

src/Files.App/Data/Models/IStatusCenterActions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Licensed under the MIT License. See the LICENSE.
33

44
using Files.App.ViewModels;
5-
using Files.Shared.Enums;
65
using System;
76
using System.Threading;
87

src/Files.App/Data/Models/ItemViewModel.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
using Files.App.Helpers.StorageCache;
55
using Files.App.ViewModels.Previews;
66
using Files.Core.Services.SizeProvider;
7-
using Files.Shared.Cloud;
8-
using Files.Shared.EventArguments;
9-
using Files.Shared.Services;
7+
using FluentFTP;
108
using LibGit2Sharp;
119
using Microsoft.Extensions.Logging;
1210
using Microsoft.UI.Xaml.Data;

src/Files.App/Dialogs/AddItemDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Files.Core.Services;
66
using Files.Core.ViewModels.Dialogs;
77
using Files.Core.ViewModels.Dialogs.AddItemDialog;
8-
using Files.Shared.Enums;
98
using Microsoft.UI.Xaml;
109
using Microsoft.UI.Xaml.Controls;
1110
using System;

src/Files.App/Dialogs/CreateShortcutDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.ViewModels.Dialogs;
55
using Files.Core.ViewModels.Dialogs;
6-
using Files.Shared.Enums;
76
using Microsoft.UI.Xaml.Controls;
87
using Microsoft.UI.Xaml.Data;
98
using System;

src/Files.App/Dialogs/DynamicDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.Helpers;
55
using Files.App.ViewModels.Dialogs;
6-
using Files.Shared.Enums;
76
using Microsoft.UI.Xaml.Controls;
87
using System;
98
using System.Threading.Tasks;

src/Files.App/Dialogs/ElevateConfirmDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Licensed under the MIT License. See the LICENSE.
33

44
using Files.Core.ViewModels.Dialogs;
5-
using Files.Shared.Enums;
65
using Microsoft.UI.Xaml.Controls;
76
using System;
87
using System.Threading.Tasks;

src/Files.App/Dialogs/FilesystemOperationDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Files.App.Utils;
66
using Files.Core.ViewModels.Dialogs;
77
using Files.Core.ViewModels.Dialogs.FileSystemDialog;
8-
using Files.Shared.Enums;
98
using Microsoft.UI.Xaml;
109
using Microsoft.UI.Xaml.Controls;
1110
using Microsoft.UI.Xaml.Media;

src/Files.App/Dialogs/ReorderSidebarItemsDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using Files.App.Extensions;
77
using Files.App.ViewModels.Dialogs;
88
using Files.Core.ViewModels.Dialogs;
9-
using Files.Shared.Enums;
109
using Microsoft.UI.Xaml;
1110
using Microsoft.UI.Xaml.Controls;
1211
using Microsoft.UI.Xaml.Input;

src/Files.App/Dialogs/SettingsDialog.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.Views.Settings;
55
using Files.Core.ViewModels.Dialogs;
6-
using Files.Shared.Enums;
76
using Microsoft.UI.Xaml;
87
using Microsoft.UI.Xaml.Controls;
98
using System;

src/Files.App/GlobalUsings.cs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@
1313
global using global::System.Diagnostics;
1414
global using SystemIO = global::System.IO;
1515

16-
// Windows Community Toolkit
16+
// CommunityToolkit.Mvvm
1717
global using global::CommunityToolkit.Mvvm.ComponentModel;
1818
global using global::CommunityToolkit.Mvvm.DependencyInjection;
1919
global using global::CommunityToolkit.Mvvm.Input;
2020
global using global::CommunityToolkit.Mvvm.Messaging;
2121

22-
// Files Front-end
22+
// Files.App
2323
global using global::Files.App.Commands;
2424
global using global::Files.App.Contexts;
2525
global using global::Files.App.Helpers;
@@ -52,28 +52,26 @@
5252
global using global::Files.App.Views.Shells;
5353

5454
// Files.Core
55-
global using global::Files.Core.CommandLine;
5655
global using global::Files.Core.Data.Enums;
56+
global using global::Files.Core.Data.EventArguments;
57+
global using global::Files.Core.Data.Items;
5758
global using global::Files.Core.Data.Messages;
5859
global using global::Files.Core.Data.Models;
5960
global using global::Files.Core.Extensions;
6061
global using global::Files.Core.Helpers;
6162
global using global::Files.Core.Services;
63+
global using global::Files.Core.Services.DateTimeFormatter;
6264
global using global::Files.Core.Services.Settings;
63-
//global using global::Files.Core.Services.SizeProvider;
6465
global using global::Files.Core.ViewModels;
6566
global using global::Files.Core.ViewModels.Dialogs;
6667
global using global::Files.Core.ViewModels.Dialogs.AddItemDialog;
6768
global using global::Files.Core.ViewModels.Dialogs.FileSystemDialog;
6869
global using global::Files.Core.ViewModels.FileTags;
6970
global using global::Files.Core.ViewModels.Widgets;
71+
global using global::Files.Core.Utils;
72+
global using global::Files.Core.Utils.Cloud;
73+
global using global::Files.Core.Utils.CommandLine;
7074

7175
// Files.Shared
7276
global using global::Files.Shared;
73-
global using global::Files.Shared.Enums;
7477
global using global::Files.Shared.Extensions;
75-
76-
// Files Back-end
77-
78-
// Vanara
79-
//global using global::Vanara.PInvoke;

src/Files.App/Helpers/Dialog/DialogDisplayHelper.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.Dialogs;
55
using Files.App.ViewModels.Dialogs;
6-
using Files.Shared.Enums;
76
using Microsoft.UI.Xaml.Controls;
87
using System;
98
using System.Threading.Tasks;

src/Files.App/Helpers/Dialog/DynamicDialogFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public static DynamicDialog GetFor_RenameDialog()
132132
return dialog;
133133
}
134134

135-
public static DynamicDialog GetFor_FileInUseDialog(List<Shared.Win32Process> lockingProcess = null)
135+
public static DynamicDialog GetFor_FileInUseDialog(List<Win32Process> lockingProcess = null)
136136
{
137137
DynamicDialog dialog = new DynamicDialog(new DynamicDialogViewModel()
138138
{

src/Files.App/Helpers/EnumConversionHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Enums;
54
using Windows.Storage;
65

76
namespace Files.App.Helpers

src/Files.App/Helpers/Navigation/NavigationHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using Files.Core.Helpers;
1212
using Files.Core.Services.Settings;
1313
using Files.Shared;
14-
using Files.Shared.Enums;
1514
using Microsoft.Extensions.Logging;
1615
using System;
1716
using System.Collections.Generic;

src/Files.App/Helpers/PostBannerHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Files.App.Extensions;
66
using Files.App.Utils;
77
using Files.App.ViewModels;
8-
using Files.Shared.Enums;
98
using System.Collections.Generic;
109
using System.Linq;
1110
using System.Threading;

src/Files.App/Helpers/Storage/ErrorCodeConverter.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Enums;
5-
64
namespace Files.App.Helpers
75
{
86
public static class ErrorCodeConverter

src/Files.App/Helpers/Storage/StorageHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using Files.App.Utils;
55
using Files.App.Utils.StorageItems;
66
using Files.Core.Helpers;
7-
using Files.Shared.Enums;
87
using System;
98
using System.Diagnostics;
109
using System.Runtime.InteropServices;

src/Files.App/Helpers/Storage/StorageItemIconHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Enums;
54
using System;
65
using System.Threading.Tasks;
76
using Windows.Storage;

src/Files.App/Helpers/StorageItemCollection/GroupingHelper.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Services.DateTimeFormatter;
54
using Windows.Storage;
65

76
namespace Files.App.Helpers

src/Files.App/Helpers/StorageItemCollection/SortingHelper.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.App.Utils;
5-
using Files.Shared.Enums;
64
using System;
75
using System.Collections.Generic;
86
using System.Linq;

src/Files.App/Helpers/UI/AppSystemBackdrop.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ protected override void OnTargetDisconnected(ICompositionSupportsSystemBackdrop
6464
userSettingsService.OnSettingChangedEvent -= OnSettingChanged;
6565
}
6666

67-
private void OnSettingChanged(object? sender, Shared.EventArguments.SettingChangedEventArgs e)
67+
private void OnSettingChanged(object? sender, SettingChangedEventArgs e)
6868
{
6969
if (target is null)
7070
return;

src/Files.App/Helpers/UI/JumpListHelper.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using CommunityToolkit.Mvvm.DependencyInjection;
55
using Files.App.UserControls.Widgets;
6-
using Files.Shared.Services;
76
using Microsoft.Extensions.Logging;
87
using System;
98
using System.Threading.Tasks;

src/Files.App/Helpers/UI/UIHelpers.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using Files.App.Utils.Shell;
77
using Files.Core.ViewModels.Dialogs;
88
using Files.Shared;
9-
using Files.Shared.Enums;
109
using Microsoft.UI.Xaml.Controls;
1110
using Microsoft.UI.Xaml.Media;
1211
using Microsoft.UI.Xaml.Media.Imaging;

src/Files.App/MainWindow.xaml.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Licensed under the MIT License. See the LICENSE.
33

44
using Files.App.UserControls.MultitaskingControl;
5+
using Files.Core.Utils.CommandLine;
56
using Microsoft.UI;
67
using Microsoft.UI.Windowing;
78
using Microsoft.UI.Xaml.Controls;

src/Files.App/Services/DateTimeFormatter/AbstractDateTimeFormatter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Services.DateTimeFormatter;
54
using System.Globalization;
65
using Windows.Globalization;
76

src/Files.App/Services/DateTimeFormatter/DateTimeFormatterFactory.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Enums;
5-
using Files.Shared.Services.DateTimeFormatter;
64
using System;
75

86
namespace Files.App.Services.DateTimeFormatter

src/Files.App/Services/DateTimeFormatter/UserDateTimeFormatter.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.EventArguments;
5-
using Files.Shared.Services.DateTimeFormatter;
6-
74
namespace Files.App.Services.DateTimeFormatter
85
{
96
internal class UserDateTimeFormatter : IDateTimeFormatter

src/Files.App/Services/DialogService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using Files.Core.ViewModels.Dialogs;
88
using Files.Core.ViewModels.Dialogs.AddItemDialog;
99
using Files.Core.ViewModels.Dialogs.FileSystemDialog;
10-
using Files.Shared.Enums;
1110
using Microsoft.Extensions.Logging;
1211
using Microsoft.UI.Xaml.Controls;
1312
using Windows.Foundation.Metadata;

src/Files.App/Services/JumpListService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Services;
54
using System.IO;
65
using Windows.Storage;
76
using Windows.UI.StartScreen;

src/Files.App/Services/Settings/AppSettingsService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.Utils.Serialization;
55
using Files.Core.Services.Settings;
6-
using Files.Shared.EventArguments;
76
using Microsoft.AppCenter.Analytics;
87

98
namespace Files.App.Services.Settings

src/Files.App/Services/Settings/AppearanceSettingsService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.Utils.Serialization;
55
using Files.Core.Services.Settings;
6-
using Files.Shared.EventArguments;
76
using Microsoft.AppCenter.Analytics;
87
using Microsoft.UI.Composition.SystemBackdrops;
98
using System;

src/Files.App/Services/Settings/FoldersSettingsService.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.App.Utils.Serialization;
5-
using Files.Shared.EventArguments;
64
using Microsoft.AppCenter.Analytics;
75

86
namespace Files.App.Services.Settings

src/Files.App/Services/Settings/GeneralSettingsService.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33

44
using Files.App.Utils.Serialization;
55
using Files.Core.Services.Settings;
6-
using Files.Shared.Enums;
7-
using Files.Shared.EventArguments;
86
using Microsoft.AppCenter.Analytics;
97
using System.Collections.Generic;
108

src/Files.App/Services/Settings/PreviewPaneSettingsService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using Files.App.Utils.Serialization;
55
using Files.Core.Services.Settings;
6-
using Files.Shared.EventArguments;
76
using Microsoft.AppCenter.Analytics;
87
using System;
98

src/Files.App/Services/Settings/UserSettingsService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Files.App.Utils.Serialization;
66
using Files.App.Utils.Serialization.Implementation;
77
using Files.Core.Services.Settings;
8-
using Files.Shared.EventArguments;
98
using Files.Shared.Extensions;
109
using System.Collections.Generic;
1110
using System.IO;

src/Files.App/UserControls/DataGridHeader.xaml.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
// Copyright (c) 2023 Files Community
22
// Licensed under the MIT License. See the LICENSE.
33

4-
using Files.Shared.Enums;
54
using Microsoft.UI.Xaml;
65
using Microsoft.UI.Xaml.Controls;
76
using System.ComponentModel;
87
using System.Runtime.CompilerServices;
98
using System.Windows.Input;
109

11-
// Il modello di elemento Controllo utente è documentato all'indirizzo https://go.microsoft.com/fwlink/?LinkId=234236
12-
1310
namespace Files.App.UserControls
1411
{
1512
public sealed partial class DataGridHeader : UserControl, INotifyPropertyChanged

0 commit comments

Comments
 (0)