Add support for creating google docs files from the "new" menu (#8784)

Author: gave92

src/Files.Launcher/Helpers/ShellNewMenuHelper.cs

@@ -69,9 +69,10 @@ private static async Task<ShellNewEntry> GetShellNewRegistryEntries(RegistryKey
         private static async Task<ShellNewEntry> ParseShellNewRegistryEntry(RegistryKey key, RegistryKey root)
         {
             var valueNames = key.GetValueNames();
-            if (!valueNames.Contains("NullFile") &&
-                !valueNames.Contains("ItemName") &&
-                !valueNames.Contains("FileName"))
+            if (!valueNames.Contains("NullFile", StringComparer.OrdinalIgnoreCase) &&
+                !valueNames.Contains("ItemName", StringComparer.OrdinalIgnoreCase) &&
+                !valueNames.Contains("FileName", StringComparer.OrdinalIgnoreCase) &&
+                !valueNames.Contains("Command", StringComparer.OrdinalIgnoreCase))
             {
                 return null;
             }

src/Files.Uwp/CommandLine/CommandLineParser.cs

@@ -10,7 +10,7 @@ internal class CommandLineParser
     {
         public static ParsedCommands ParseUntrustedCommands(string cmdLineString)
         {
-            var parsedArgs = Parse(SplitArguments(cmdLineString));
+            var parsedArgs = Parse(SplitArguments(cmdLineString, true));
             return ParseSplitArguments(parsedArgs);
         }
 
@@ -76,7 +76,7 @@ private static ParsedCommands ParseSplitArguments(List<KeyValuePair<string, stri
             return commands;
         }
 
-        private static string[] SplitArguments(string commandLine)
+        public static string[] SplitArguments(string commandLine, bool trimQuotes = false)
         {
             char[] commandLineCharArray = commandLine.ToCharArray();
             bool isInQuote = false;
@@ -94,7 +94,14 @@ private static string[] SplitArguments(string commandLine)
                 }
             }
 
-            return new string(commandLineCharArray).Replace("\"", "", StringComparison.Ordinal).Split('\n');
+            if (trimQuotes)
+            {
+                return new string(commandLineCharArray).Replace("\"", "", StringComparison.Ordinal).Split('\n');
+            }
+            else
+            {
+                return new string(commandLineCharArray).Split('\n');
+            }
         }
 
         public static List<KeyValuePair<string, string>> Parse(string[] args = null)

src/Files.Uwp/Extensions/ShellNewEntryExtensions.cs

@@ -10,6 +10,7 @@
 using Windows.ApplicationModel.AppService;
 using Windows.Foundation.Collections;
 using Windows.Storage;
+using System.Linq;
 
 namespace Files.Extensions
 {
@@ -60,19 +61,39 @@ public static async Task<FilesystemResult<BaseStorageFile>> Create(this ShellNew
             var parentFolder = await associatedInstance.FilesystemViewModel.GetFolderFromPathAsync(PathNormalization.GetParentDir(filePath));
             if (parentFolder)
             {
-                return await Create(shellEntry, parentFolder, Path.GetFileName(filePath));
+                return await Create(shellEntry, parentFolder, filePath);
             }
             return new FilesystemResult<BaseStorageFile>(null, parentFolder.ErrorCode);
         }
 
-        public static async Task<FilesystemResult<BaseStorageFile>> Create(this ShellNewEntry shellEntry, BaseStorageFolder parentFolder, string fileName)
+        public static async Task<FilesystemResult<BaseStorageFile>> Create(this ShellNewEntry shellEntry, BaseStorageFolder parentFolder, string filePath)
         {
             FilesystemResult<BaseStorageFile> createdFile = null;
+            var fileName = Path.GetFileName(filePath);
             if (!fileName.EndsWith(shellEntry.Extension, StringComparison.Ordinal))
             {
                 fileName += shellEntry.Extension;
             }
-            if (shellEntry.Template == null)
+            if (shellEntry.Command != null)
+            {
+                var args = CommandLine.CommandLineParser.SplitArguments(shellEntry.Command);
+                if (args.Any())
+                {
+                    var connection = await AppServiceConnectionHelper.Instance;
+                    if (connection != null)
+                    {
+                        _ = await connection.SendMessageForResponseAsync(new ValueSet()
+                        {
+                            { "Arguments", "LaunchApp" },
+                            { "WorkingDirectory", PathNormalization.GetParentDir(filePath) },
+                            { "Application", args[0].Replace("\"", "", StringComparison.Ordinal) },
+                            { "Parameters", string.Join(" ", args.Skip(1)).Replace("%1", filePath) }
+                        });
+                    }
+                }
+                createdFile = new FilesystemResult<BaseStorageFile>(null, Shared.Enums.FileSystemStatusCode.Success);
+            }
+            else if (shellEntry.Template == null)
             {
                 createdFile = await FilesystemTasks.Wrap(() => parentFolder.CreateFileAsync(fileName, CreationCollisionOption.GenerateUniqueName).AsTask());
             }

src/Files.Uwp/Helpers/UIFilesystemHelpers.cs

@@ -313,17 +313,22 @@ public static async Task<IStorageItem> CreateFileFromDialogResultTypeForResult(A
                 }
             }
 
-            // Show rename dialog
-            DynamicDialog dialog = DynamicDialogFactory.GetFor_RenameDialog();
-            await dialog.ShowAsync();
-
-            if (dialog.DynamicResult != DynamicDialogResult.Primary)
+            // Skip rename dialog when ShellNewEntry has a Command (e.g. ".accdb", ".gdoc")
+            string userInput = null;
+            if (itemType != AddItemDialogItemType.File || itemInfo?.Command == null)
             {
-                return null;
+                DynamicDialog dialog = DynamicDialogFactory.GetFor_RenameDialog();
+                await dialog.ShowAsync(); // Show rename dialog
+
+                if (dialog.DynamicResult != DynamicDialogResult.Primary)
+                {
+                    return null;
+                }
+
+                userInput = dialog.ViewModel.AdditionalData as string;
             }
 
             // Create file based on dialog result
-            string userInput = dialog.ViewModel.AdditionalData as string;
             var folderRes = await associatedInstance.FilesystemViewModel.GetFolderWithPathFromPathAsync(currentPath);
             var created = new FilesystemResult<(ReturnResult, IStorageItem)>((ReturnResult.Failed, null), FileSystemStatusCode.Generic);
             if (folderRes)