Skip to content

Commit 3cf5671

Browse files
authored
Removed vertical tab flyout (#9786)
1 parent a8d48f0 commit 3cf5671

File tree

13 files changed

+451
-1665
lines changed

13 files changed

+451
-1665
lines changed

src/Files.Backend/Services/Settings/IMultitaskingSettingsService.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ namespace Files.Backend.Services.Settings
44
{
55
public interface IMultitaskingSettingsService : IBaseSettingsService, INotifyPropertyChanged
66
{
7-
/// <summary>
8-
/// Gets or sets a value indicating whether or not to enable the vertical tab flyout.
9-
/// </summary>
10-
bool IsVerticalTabFlyoutEnabled { get; set; }
117

128
/// <summary>
139
/// Gets or sets a value indicating whether or not to enable dual pane feature.

src/Files.Uwp/Files.Uwp.csproj

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -542,9 +542,6 @@
542542
<DependentUpon>OngoingTasksFlyout.xaml</DependentUpon>
543543
</Compile>
544544
<Compile Include="UserControls\MultitaskingControl\TabItem\TabItem.cs" />
545-
<Compile Include="UserControls\MultitaskingControl\VerticalTabViewControl.xaml.cs">
546-
<DependentUpon>VerticalTabViewControl.xaml</DependentUpon>
547-
</Compile>
548545
<Compile Include="UserControls\Widgets\DrivesWidget.xaml.cs">
549546
<DependentUpon>DrivesWidget.xaml</DependentUpon>
550547
</Compile>
@@ -1241,14 +1238,6 @@
12411238
<SubType>Designer</SubType>
12421239
<Generator>MSBuild:Compile</Generator>
12431240
</Page>
1244-
<Page Include="ResourceDictionaries\TabViewItem_shared.xaml">
1245-
<SubType>Designer</SubType>
1246-
<Generator>MSBuild:Compile</Generator>
1247-
</Page>
1248-
<Page Include="ResourceDictionaries\TabView_vertical.xaml">
1249-
<SubType>Designer</SubType>
1250-
<Generator>MSBuild:Compile</Generator>
1251-
</Page>
12521241
<Page Include="ResourceDictionaries\RightAlignedToggleSwitchStyle.xaml">
12531242
<Generator>MSBuild:Compile</Generator>
12541243
<SubType>Designer</SubType>
@@ -1397,10 +1386,6 @@
13971386
<SubType>Designer</SubType>
13981387
<Generator>MSBuild:Compile</Generator>
13991388
</Page>
1400-
<Page Include="UserControls\MultitaskingControl\VerticalTabViewControl.xaml">
1401-
<SubType>Designer</SubType>
1402-
<Generator>MSBuild:Compile</Generator>
1403-
</Page>
14041389
<Page Include="UserControls\Widgets\BundlesWidget.xaml">
14051390
<SubType>Designer</SubType>
14061391
<Generator>MSBuild:Compile</Generator>

src/Files.Uwp/ResourceDictionaries/TabViewItem_shared.xaml

Lines changed: 0 additions & 465 deletions
This file was deleted.

src/Files.Uwp/ResourceDictionaries/TabView_vertical.xaml

Lines changed: 0 additions & 309 deletions
This file was deleted.

src/Files.Uwp/ServicesImplementation/Settings/MultitaskingSettingsService.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@ public MultitaskingSettingsService(ISettingsSharingContext settingsSharingContex
1313
RegisterSettingsContext(settingsSharingContext);
1414
}
1515

16-
public bool IsVerticalTabFlyoutEnabled
17-
{
18-
get => Get(true);
19-
set => Set(value);
20-
}
21-
2216
public bool IsDualPaneEnabled
2317
{
2418
get => Get(false);
@@ -35,7 +29,6 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
3529
{
3630
switch (e.SettingName)
3731
{
38-
case nameof(IsVerticalTabFlyoutEnabled):
3932
case nameof(IsDualPaneEnabled):
4033
case nameof(AlwaysOpenDualPaneInNewTab):
4134
Analytics.TrackEvent($"{e.SettingName} {e.NewValue}");
@@ -47,7 +40,6 @@ protected override void RaiseOnSettingChangedEvent(object sender, SettingChanged
4740

4841
public void ReportToAppCenter()
4942
{
50-
Analytics.TrackEvent($"{nameof(IsVerticalTabFlyoutEnabled)}, {IsVerticalTabFlyoutEnabled}");
5143
Analytics.TrackEvent($"{nameof(IsDualPaneEnabled)}, {IsDualPaneEnabled}");
5244
Analytics.TrackEvent($"{nameof(AlwaysOpenDualPaneInNewTab)}, {AlwaysOpenDualPaneInNewTab}");
5345
}

src/Files.Uwp/Strings/en-US/Resources.resw

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -810,12 +810,6 @@
810810
<data name="NavUpButton.AutomationProperties.Name" xml:space="preserve">
811811
<value>Go up one directory</value>
812812
</data>
813-
<data name="VerticalTabFlyout.AutomationProperties.Name" xml:space="preserve">
814-
<value>Vertical tab flyout</value>
815-
</data>
816-
<data name="VerticalTabFlyout.ToolTipService.ToolTip" xml:space="preserve">
817-
<value>Vertical tab flyout</value>
818-
</data>
819813
<data name="SettingsPreferencesAppLanguage.Title" xml:space="preserve">
820814
<value>Language</value>
821815
</data>
@@ -2013,9 +2007,6 @@
20132007
<data name="SecurityUnknownOwnerText.Text" xml:space="preserve">
20142008
<value>Unknown owner</value>
20152009
</data>
2016-
<data name="SettingsVerticalTabFlyout" xml:space="preserve">
2017-
<value>Display the vertical tab flyout on the title bar</value>
2018-
</data>
20192010
<data name="SettingsThemesLearnMoreButton.AutomationProperties.Name" xml:space="preserve">
20202011
<value>Learn more about custom themes</value>
20212012
</data>
Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
<UserControl
2-
x:Class="Files.Uwp.UserControls.MultitaskingControl.TabItemControl"
3-
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
4-
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
5-
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
6-
xmlns:local="using:Files.Uwp.UserControls.MultitaskingControl"
7-
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
8-
d:DesignHeight="300"
9-
d:DesignWidth="400"
10-
mc:Ignorable="d">
2+
x:Class="Files.Uwp.UserControls.MultitaskingControl.TabItemControl"
3+
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
4+
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
5+
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
6+
xmlns:local="using:Files.Uwp.UserControls.MultitaskingControl"
7+
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
8+
d:DesignHeight="300"
9+
d:DesignWidth="400"
10+
mc:Ignorable="d">
1111

12-
<Frame
13-
x:Name="ContentFrame"
14-
Background="Transparent"
15-
CacheSize="0"
16-
IsNavigationStackEnabled="False"
17-
Navigated="ContentFrame_Navigated" />
12+
<Frame
13+
x:Name="ContentFrame"
14+
Background="Transparent"
15+
CacheSize="0"
16+
IsNavigationStackEnabled="False"
17+
Navigated="ContentFrame_Navigated" />
1818
</UserControl>

src/Files.Uwp/UserControls/MultitaskingControl/VerticalTabViewControl.xaml

Lines changed: 0 additions & 131 deletions
This file was deleted.

0 commit comments

Comments
 (0)