Remove delay of loading sidebar items and other services on startup (#7104)

Author: winston-de

Files/App.xaml.cs

@@ -155,13 +155,13 @@ private static async Task StartAppCenter()
             }
         }
 
-        public static async Task LoadOtherStuffAsync()
+        private static async Task InitializeAppComponentsAsync()
         {
             // Start off a list of tasks we need to run before we can continue startup
-            await StartAppCenter();
             await Task.Run(async () =>
             {
                 await Task.WhenAll(
+                    StartAppCenter(),
                     DrivesManager.EnumerateDrivesAsync(),
                     CloudDrivesManager.EnumerateDrivesAsync(),
                     LibraryManager.EnumerateLibrariesAsync(),
@@ -196,13 +196,14 @@ protected override async void OnLaunched(LaunchActivatedEventArgs e)
         {
             await logWriter.InitializeAsync("debug.log");
             Logger.Info($"App launched. Prelaunch: {e.PrelaunchActivated}");
-
+            
             //start tracking app usage
             SystemInformation.Instance.TrackAppUse(e);
 
             bool canEnablePrelaunch = ApiInformation.IsMethodPresent("Windows.ApplicationModel.Core.CoreApplication", "EnablePrelaunch");
 
             await EnsureSettingsAndConfigurationAreBootstrapped();
+            InitializeAppComponentsAsync().ContinueWith(t => Logger.Warn(t.Exception, "Error during LoadOtherStuffAsync()"), TaskContinuationOptions.OnlyOnFaulted);
 
             var rootFrame = EnsureWindowIsInitialized();
 
@@ -260,6 +261,7 @@ protected override async void OnFileActivated(FileActivatedEventArgs e)
             SystemInformation.Instance.TrackAppUse(e);
 
             await EnsureSettingsAndConfigurationAreBootstrapped();
+            InitializeAppComponentsAsync().ContinueWith(t => Logger.Warn(t.Exception, "Error during LoadOtherStuffAsync()"), TaskContinuationOptions.OnlyOnFaulted);
 
             var rootFrame = EnsureWindowIsInitialized();
 
@@ -325,6 +327,7 @@ protected override async void OnActivated(IActivatedEventArgs args)
             Logger.Info($"App activated by {args.Kind.ToString()}");
 
             await EnsureSettingsAndConfigurationAreBootstrapped();
+            InitializeAppComponentsAsync().ContinueWith(t => Logger.Warn(t.Exception, "Error during LoadOtherStuffAsync()"), TaskContinuationOptions.OnlyOnFaulted);
 
             var rootFrame = EnsureWindowIsInitialized();
 

Files/Views/MainPage.xaml.cs

@@ -337,8 +337,6 @@ private void Page_Loaded(object sender, RoutedEventArgs e)
             {
                 _ = VisualStateManager.GoToState(this, nameof(HorizontalTabViewCollapsed), true);
             }
-
-            App.LoadOtherStuffAsync().ContinueWith(t => App.Logger.Warn(t.Exception, "Error during LoadOtherStuffAsync()"), TaskContinuationOptions.OnlyOnFaulted);
         }
 
         private void ToggleFullScreenAccelerator(KeyboardAcceleratorInvokedEventArgs e)