Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] RPC支持加入错误类型error type #5334

Closed
1 task
Tracked by #5287
Fatman13 opened this issue Sep 30, 2022 · 9 comments
Closed
1 task
Tracked by #5287

[RPC] RPC支持加入错误类型error type #5334

Fatman13 opened this issue Sep 30, 2022 · 9 comments
Labels
C-dev-productivity Category: Developer productivity CU-chain-service Venus chain service related issues

Comments

@Fatman13
Copy link
Contributor

Fatman13 commented Sep 30, 2022

为了支持 filecoin-project/lotus#9294 ,在lotusmaster中加入了 filecoin-project/lotus#9061 ,不确定Venus是不是需要?另外,这个Lotus-miner考虑在用这个方式解决daemon高可用的问题,和chain-co是2个方法。参考一下?

关联:

@Fatman13 Fatman13 added C-dev-productivity Category: Developer productivity CU-chain-service Venus chain service related issues C-triage Category: Need triage labels Sep 30, 2022
@hunjixin
Copy link
Contributor

要的,后面想办法把我们的rpc库和官方的rpc库合并到一起去

@zl03jsj
Copy link
Contributor

zl03jsj commented Oct 6, 2022

lotus开发团队在json-rpc库中加入更详细的错误信息, 起因要从这个下面的问题说起:

由于在例如bafy2bzacebgkmblyhe5jptkdyiaq5euk6o4w5pdgdhxfeegt4thyp4jf2svea消息(DeclareFaultsRecovered)中,
一次性'批量'了太多的sector, 有可能导致超出block gas limit.
lotus团队虽然提出了配置最大分区数的方法, 但是他们依然想要更加智能的处理这种情况:
即自动把消息中的大量的sector拆分到多个合适的消息中去. 从而引出了:

filecoin-project/lotus#9041

而要实现更智能的处理上述问题, 更加准确的rpc错误信息是一个基础.

我们已经在自己fork的分支中做了大量的改动或优化, 统一RPC库时, 如何取舍我们'自己'的优化是一个问题.

但无论如何, 把我们自己的rpc库与lotus团队维护的rpc库保持一致, 是一种明智的做法.

@Fatman13
Copy link
Contributor Author

@hunjixin @simlecode 这个后来lotus他们是合了吗?

@simlecode
Copy link
Collaborator

@hunjixin @simlecode 这个后来lotus他们是合了吗?

看了下还没有

@simlecode
Copy link
Collaborator

simlecode commented Nov 21, 2022

@Fatman13
Copy link
Contributor Author

Fatman13 commented Dec 9, 2022

😂。。看来是没人合了。。能review里面,请求他们人来review么?

@Fatman13
Copy link
Contributor Author

这个官方还是没有合?尴尬。。。😂

@Fatman13
Copy link
Contributor Author

RPC 的好像官方那边 @magik6k 还没有 review。这咋办?
image

@Fatman13
Copy link
Contributor Author

已经有 #5346 了。

@Fatman13 Fatman13 closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-dev-productivity Category: Developer productivity CU-chain-service Venus chain service related issues
Projects
Status: Done
Development

No branches or pull requests

4 participants