Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Allow publishing deals using control addresses #1317

Closed
magik6k opened this issue Dec 2, 2020 · 1 comment · Fixed by #1321
Closed

Allow publishing deals using control addresses #1317

magik6k opened this issue Dec 2, 2020 · 1 comment · Fixed by #1321
Assignees
Labels
change-behaviour Changes behaviour or state interpretation, necessitating a network version upgrade enhancement New feature or request

Comments

@magik6k
Copy link
Contributor

magik6k commented Dec 2, 2020

Currently PublishStorageDeals requires deals to be published from miner worker address:

_, worker, _ := builtin.RequestMinerControlAddrs(rt, provider)
if worker != rt.Caller() {

We could also allow control addresses here to give miners more flexibility

@anorth anorth added change-behaviour Changes behaviour or state interpretation, necessitating a network version upgrade enhancement New feature or request labels Dec 3, 2020
@anorth anorth self-assigned this Dec 3, 2020
@anorth
Copy link
Member

anorth commented Dec 4, 2020

Sounds good.

The market actor restricts one other action to the worker address: withdrawing funds. The recipient of the withdrawal is always the miner owner address, but the worker is allowed to trigger it. Should we also allow control addresses to request withdrawal? Let's file a new issue if so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
change-behaviour Changes behaviour or state interpretation, necessitating a network version upgrade enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants