Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Add an FRC42 endpoint for EVM calls #1256

Closed
Stebalien opened this issue Dec 12, 2022 · 4 comments
Closed

EVM: Add an FRC42 endpoint for EVM calls #1256

Stebalien opened this issue Dec 12, 2022 · 4 comments
Assignees
@Stebalien
Milestone
M2.1 (rr11) Carbo...

Comments

@Stebalien
Copy link
Member

I'm a bit concerned that users will start hard-coding the current InvokeContract method number, making it difficult for "native" actors to implement EVM calling. We can likely punt on this, but that should be an explicit decision.
@Stebalien Stebalien added this to the M2.1 (rr10) Carbonado milestone Dec 13, 2022
@Stebalien
Copy link
Member Author

So, this is also important for off-chain calls. Right now, we use method 2 which will produce not-so-great errors. Ideally, we'd:

  1. Use an RFC42 method number.
  2. In either the FVM or lotus, augment the backtrace with some information about why the method may not have been supported (e.g., look for well-known FRC42 method numbers).

@Stebalien
Copy link
Member Author

This is also an issue for on-chain calls. Right now, we just invoke method 2 without really thinking about it, which will likely cause issues in the future.

We should implement this now.

@Stebalien Stebalien mentioned this issue Jan 4, 2023
Closed
@Stebalien
Copy link
Member Author

Specifically:

  1. Add an FRC42 method for calling.
  2. Always use it, even EVM -> EVM.

@Stebalien Stebalien assigned arajasek and mriise and unassigned arajasek Jan 4, 2023
@mriise mriise linked a pull request Jan 10, 2023 that will close this issue
EVM: Add frc-42 method numbers filecoin-project/builtin-actors#1007
Closed
Stebalien added a commit to filecoin-project/builtin-actors that referenced this issue Jan 12, 2023
@Stebalien
EVM: use FRC-0042 for invoke
76a38c6 
This also re-numbers all the other method numbers, because we're
removing method 2. This is going to be annoying... but it's better to do
this now than to have a dead method.

fixes filecoin-project/ref-fvm#1256
@Stebalien Stebalien mentioned this issue Jan 12, 2023
Merged
Stebalien added a commit to filecoin-project/builtin-actors that referenced this issue Jan 12, 2023
@Stebalien
EVM: use FRC-0042 for invoke
4c94a95 
This also re-numbers all the other method numbers, because we're
removing method 2. This is going to be annoying... but it's better to do
this now than to have a dead method.

fixes filecoin-project/ref-fvm#1256
@Stebalien Stebalien assigned Stebalien and unassigned mriise Jan 12, 2023
Stebalien added a commit to filecoin-project/builtin-actors that referenced this issue Jan 12, 2023
@Stebalien
EVM: use FRC-0042 for invoke (#1021)
610f399 
This also re-numbers all the other method numbers, because we're
removing method 2. This is going to be annoying... but it's better to do
this now than to have a dead method.

fixes filecoin-project/ref-fvm#1256
@maciejwitowski
Copy link
Contributor

Closing this after since filecoin-project/builtin-actors#1021 is merged (not sure why the automation didn't do it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
M2.1 (rr11) Carbonado.2
Development

Successfully merging a pull request may close this issue.

EVM: Add frc-42 method numbers filecoin-project/builtin-actors
4 participants
@Stebalien @arajasek @mriise @maciejwitowski