feat: migrations: function for migrating builtin actors with only code changes #8815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
changed the title
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
2 times, most recently
from
b4577fb to
24a2f4c
Compare
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
from
24a2f4c to
b28cb2a
Compare
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
8 times, most recently
from
6e1a894 to
fdb3547
Compare
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
6 times, most recently
from
87c7fd4 to
526acd7
Compare
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
from
526acd7 to
3c4792d
Compare
arajasek
reviewed
Jun 10, 2022
Contributor
arajasek
left a comment
arajasek
left a comment
There was a problem hiding this comment.
Generally looks good, but some things need to change.
Can you also please update actors_version_checklist to reflect this new flow under the Migration instructions.
| type ChainIO interface { | ||
| ChainReadObj(context.Context, cid.Cid) ([]byte, error) | ||
| ChainHasObj(context.Context, cid.Cid) (bool, error) | ||
| ChainPutObj(context.Context, blocks.Block) error |
Contributor
There was a problem hiding this comment.
@magik6k We had to do this just so we could use the itest framework for a migration test, which is not really what it's intended for, but is better than any of the existing frameworks we have (I think). Questions for you:
- Do you absolutely hate it and refuse to merge this PR?
- Is there a way to not expose this method over the JSON-RPC, and have it just for things like this test?
- Do you have a better way to write this test?
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
from
09cb375 to
801c670
Compare
arajasek
reviewed
Jun 10, 2022
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
from
10638a3 to
e84a778
Compare
geoff-vball
force-pushed
the
gstuart/lite-migration
branch
from
e84a778 to
3f712c3
Compare
arajasek
approved these changes
Jun 10, 2022
Contributor
arajasek
left a comment
arajasek
left a comment
There was a problem hiding this comment.
Landing lest it rot, but we do need Magik answer re: #8815 (comment).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #8780
Proposed Changes
Adds
LiteMigration()toupgrades.gowhich should allow for easy upgrades if actors code needs to change but state does not. Example provided above the function to perform all the migration duties. Checkactors_version_checklist.mdfor the rest of the steps.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps