Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Drop cache after some period #9760

Closed
5 of 15 tasks
arajasek opened this issue Nov 30, 2022 · 1 comment
Closed
5 of 15 tasks

Migrations: Drop cache after some period #9760

arajasek opened this issue Nov 30, 2022 · 1 comment
Labels
kind/enhancement Kind: Enhancement
Milestone

Comments

@arajasek
Copy link
Contributor

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

Currently, Lotus does not drop the migration cache upon a successful migration. This is intentional, as a minor reorg around the upgrade could cause us to need to rerun the migration (and we want the cache for that).

We should eventually drop this cache, though -- as far as I can tell, that only happens on node restart right now. Some heuristic like "made it 100 epochs after the migration, let's drop" might be good, though suggested approaches are welcome.

@arajasek
Copy link
Contributor Author

arajasek commented Mar 7, 2023

@travisperson's research showed this cache is actually not that large. It's not worth dropping.

@arajasek arajasek closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants