Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI step printing dependency diff #8170

Open
magik6k opened this issue Feb 22, 2022 · 3 comments
Open

CI step printing dependency diff #8170

magik6k opened this issue Feb 22, 2022 · 3 comments
Assignees
Labels
dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Kind: Enhancement

Comments

@magik6k
Copy link
Contributor

magik6k commented Feb 22, 2022

In dependency-updating PRs it would be really convenient to have a CI step which would print diffs of code in dependencies - so it's easy to see changes in deps.

This can be done with something like:

git clone -b [base branch] https://github.com/filecoin-project/lotus a
git clone -b [target branch] https://github.com/filecoin-project/lotus b
cd a
make buildall
go mod vendor
cd ../b
make buildall
go mod vendor
cd ..

diff -r --color a/vendor b/vendor

Just need to make this into a CircleCI step.

Example output comparing current master with deps/update-libp2p: https://gist.github.com/magik6k/c4013988d8230aadc1de1d9d4a9809b5

@magik6k magik6k added help wanted Extra attention is needed good first issue Good for newcomers dif/easy An existing lotus user should be able to pick this up kind/enhancement Kind: Enhancement effort/hours Effort: Hours labels Feb 22, 2022
@AleemRehman
Copy link

@magik6k / @jennijuju can have a look at this?

@jennijuju
Copy link
Member

@magik6k / @jennijuju can have a look at this?

Hi! Do you mean you wanna work on this one?

@witnsby
Copy link

witnsby commented Oct 31, 2022

Hello @jennijuju, can I be assigned to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Kind: Enhancement
Projects
Status: Ready To Work
Development

No branches or pull requests

5 participants